linux-kernel - Re: [PATCH] drivers: virtio: Make out_del_vqs dependent on BALLOON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200308165831-mutt-send-email-mst@kernel.org>
Date:   Sun, 8 Mar 2020 16:59:19 -0400
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     David Hildenbrand <david@...hat.com>
Cc:     Vincenzo Frascino <vincenzo.frascino@....com>,
        virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, Jason Wang <jasowang@...hat.com>
Subject: Re: [PATCH] drivers: virtio: Make out_del_vqs dependent on
 BALLOON_COMPACTION

On Sun, Mar 08, 2020 at 08:38:19PM +0100, David Hildenbrand wrote:
> 
> 
> > Am 06.03.2020 um 11:56 schrieb Vincenzo Frascino <vincenzo.frascino@....com>:
> > 
> > out_del_vqs label is currently used only when BALLOON_COMPACTION
> > configuration option is enabled. Having it disabled triggers the
> > following warning at compile time:
> > 
> > drivers/virtio/virtio_balloon.c: In function ‘virtballoon_probe’:
> > drivers/virtio/virtio_balloon.c:963:1: warning: label ‘out_del_vqs’
> > defined but not used [-Wunused-label]
> >  963 | out_del_vqs:
> >      | ^~~~~~~~~~~
> > 
> > Make out_del_vqs dependent on BALLOON_COMPACTION to address the
> > issue.
> > 
> > Cc: "Michael S. Tsirkin" <mst@...hat.com>
> > Cc: Jason Wang <jasowang@...hat.com>
> > Signed-off-by: Vincenzo Frascino <vincenzo.frascino@....com>
> 
> I think this is now the third patch on the list that tries to fix this warning.
> 
> Michael, can we finally queue one of these (or is there one in -next already - did not check)?
> 
> Thanks

It's queued in my tree (and will be in next eventually), I just didn't
send it to Linus yet.
Sorry about the delay.

-- 
MST