linux-kernel - Re: [PATCH 0/4] syscon: Alter syscon and reboot-mode drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 9 Mar 2020 07:13:13 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Sergey.Semin@...kalelectronics.ru
Cc:     Serge Semin <fancer.lancer@...il.com>,
        Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>,
        Maxim Kaurkin <Maxim.Kaurkin@...kalelectronics.ru>,
        Pavel Parkhomenko <Pavel.Parkhomenko@...kalelectronics.ru>,
        Ramil Zaripov <Ramil.Zaripov@...kalelectronics.ru>,
        Ekaterina Skachko <Ekaterina.Skachko@...kalelectronics.ru>,
        Vadim Vlasov <V.Vlasov@...kalelectronics.ru>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Paul Burton <paulburton@...nel.org>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Sebastian Reichel <sre@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        devicetree@...r.kernel.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] syscon: Alter syscon and reboot-mode drivers

On Fri, 06 Mar 2020, Sergey.Semin@...kalelectronics.ru wrote:

> From: Serge Semin <fancer.lancer@...il.com>
> 
> A lot of custom functionality can be tuned by means of a syscon-registers
> placed in Baikal-T1 CCU memory space (though in documentation they are
> called system devices registers). While in most of the case the syscon
> registers usage will be distributed between corresponding subsystem drivers
> (thanks to pretty much coherent design of the registers fields), there are
> some peculiarities we should reflect in the generic syscon code.
> 
> First of all seeing there is an map endiannes config acceptable by the syscon
> it would be justified to add the corresponding properties declared in the
> mfd/syscon.yaml bindings file. Don't really know why this hasn't been done
> before.
> 
> Then as it's going to be general in the framework of the Baikal-T1 SoC support
> integration into the kernel, we suggest to replace the legacy text-based
> syscon-reboot-mode dts-bindings file with yaml-based one.
> 
> Finally seeing the syscon-reboot-mode devices are mostly used in conjuction
> with just syscon-reboot device (in particular Baikal-T1 CCU WDT RCR register is
> preserved during any type of reboots) and for several other reasons (see the
> commit message for details), we suggest to add the 'regmap' property support
> to the syscon-reboot-mode driver. This would eliminate the requirement of
> placing the syscon-reboot-mode dts-node in the syscon sub-nodes area.
> 
> This patchset is rebased and tested on the mainline Linux kernel 5.6-rc4:
> commit 98d54f81e36b ("Linux 5.6-rc4").
> 
> Signed-off-by: Serge Semin <Sergey.Semin@...kalelectronics.ru>
> Signed-off-by: Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>
> Cc: Maxim Kaurkin <Maxim.Kaurkin@...kalelectronics.ru>
> Cc: Pavel Parkhomenko <Pavel.Parkhomenko@...kalelectronics.ru>
> Cc: Ramil Zaripov <Ramil.Zaripov@...kalelectronics.ru>
> Cc: Ekaterina Skachko <Ekaterina.Skachko@...kalelectronics.ru>
> Cc: Vadim Vlasov <V.Vlasov@...kalelectronics.ru>
> Cc: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
> Cc: Paul Burton <paulburton@...nel.org>
> Cc: Ralf Baechle <ralf@...ux-mips.org>
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: Sebastian Reichel <sre@...nel.org>
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: Mark Rutland <mark.rutland@....com>
> Cc: devicetree@...r.kernel.org
> Cc: linux-pm@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> 
> Serge Semin (4):
>   dt-bindings: syscon: Add syscon endian properties support
>   dt-bindings: power: reset: Replace SYSCON reboot-mode legacy bindings
>     with YAML-based one
>   dt-bindings: power: reset: Add regmap support to the SYSCON
>     reboot-mode bindings
>   power: reset: syscon-reboot-mode: Add regmap dts-property support
> 
>  .../devicetree/bindings/mfd/syscon.yaml       | 14 +++++
>  .../power/reset/syscon-reboot-mode.txt        | 35 -----------
>  .../power/reset/syscon-reboot-mode.yaml       | 58 +++++++++++++++++++
>  drivers/power/reset/syscon-reboot-mode.c      | 11 +++-
>  4 files changed, 80 insertions(+), 38 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/power/reset/syscon-reboot-mode.txt
>  create mode 100644 Documentation/devicetree/bindings/power/reset/syscon-reboot-mode.yaml

Please re-send this patch --threaded.

As it stands, it's been scattered to the 4 winds throughout my inbox.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog