linux-kernel - Re: [PATCH RFC 0/3] clean up misc device minor numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200309071347.GA4095204@kroah.com>
Date:   Mon, 9 Mar 2020 08:13:47 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Zhenzhong Duan <zhenzhong.duan@...il.com>
Cc:     linux-kernel@...r.kernel.org, jdike@...toit.com, richard@....at,
        anton.ivanov@...bridgegreys.com, miguel.ojeda.sandonis@...il.com,
        willy@...roxy.com, ksenija.stanojevic@...il.com, arnd@...db.de,
        mpm@...enic.com, herbert@...dor.apana.org.au,
        jonathan@...zard.org.uk, benh@...nel.crashing.org,
        davem@...emloft.net, b.zolnierkie@...sung.com, rjw@...ysocki.net,
        pavel@....cz, len.brown@...el.com
Subject: Re: [PATCH RFC 0/3] clean up misc device minor numbers

On Mon, Mar 09, 2020 at 10:17:44AM +0800, Zhenzhong Duan wrote:
> Some the misc device minor numbers definitions spread in different
> local c files, specially some are duplicate number with different
> name, some are same name with conflict numbers, some prefer dynamic
> minors.
> 
> This patchset try to address all of them.
> 
> To be honest, I didn't try build on arm or sparc arch which some
> drivers depend on as I have little experience on cross-compile.
> But I still checked the patch carefully to ensure it builds
> in theory. Appreciate if anyone willing to test build on those arch.
> 
> Zhenzhong Duan (3):
>   misc: cleanup minor number definitions in c file into miscdevice.h
>   misc: move FLASH_MINOR into miscdevice.h and fix conflicts
>   speakup: misc: Use dynamic minor numbers for speakup devices

Many thanks for this work, I think they all look sane except maybe the
last one, I'll respond there to that.

thanks,

greg k-h