linux-kernel - RE: [PATCH v2] EDAC: synopsys: Fix the wrong call of pinf->col parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 9 Mar 2020 08:44:44 +0000
From:   Manish Narani <MNARANI@...inx.com>
To:     Sherry Sun <sherry.sun@....com>, "bp@...en8.de" <bp@...en8.de>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "tony.luck@...el.com" <tony.luck@...el.com>,
        "james.morse@....com" <james.morse@....com>,
        "rrichter@...vell.com" <rrichter@...vell.com>,
        Michal Simek <michals@...inx.com>
CC:     "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-imx@....com" <linux-imx@....com>,
        "frank.li@....com" <frank.li@....com>
Subject: RE: [PATCH v2] EDAC: synopsys: Fix the wrong call of pinf->col
 parameter

Hi,

> -----Original Message-----
> From: Sherry Sun <sherry.sun@....com>
> Sent: Friday, February 28, 2020 7:46 AM
> To: bp@...en8.de; mchehab@...nel.org; tony.luck@...el.com;
> james.morse@....com; rrichter@...vell.com; Michal Simek
> <michals@...inx.com>; Manish Narani <MNARANI@...inx.com>
> Cc: linux-edac@...r.kernel.org; linux-kernel@...r.kernel.org; linux-
> imx@....com; frank.li@....com
> Subject: [PATCH v2] EDAC: synopsys: Fix the wrong call of pinf->col parameter
> 
> Since ZynqMP platform call zynqmp_get_error_info() function to get ce/ue
> information. In this function, pinf->col parameter is not used, this
> parameter is only used by Zynq platforme in zynq_get_error_info(). So
> here pinf->col should not be called and printed for ZynqMP, need remove
> it.
> 
> Fixes: b500b4a029d57 ("EDAC, synopsys: Add ECC support for ZynqMP DDR
> controller")
> Signed-off-by: Sherry Sun <sherry.sun@....com>

Reviewed-by: Manish Narani <manish.narani@...inx.com>

Thanks,
Manish