linux-kernel - Re: [PATCH] drm/amdgpu: Correct the condition of warning while bo release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9da8f3a9-5d28-37b9-cda6-8be336068e7b@amd.com>
Date:   Mon, 9 Mar 2020 15:45:04 +0100
From:   Christian König <christian.koenig@....com>
To:     xinhui pan <xinhui.pan@....com>, linux-kernel@...r.kernel.org
Cc:     nicholas.johnson-opensource@...look.com.au, Felix.Kuehling@....com,
        Alexander.Deucher@....com
Subject: Re: [PATCH] drm/amdgpu: Correct the condition of warning while bo
 release

Am 09.03.20 um 15:34 schrieb xinhui pan:
> Only kernel bo has kfd eviction fence.
> This warning is to give a notice that kfd only remove eviction fence on
> individual bos.
>
> Signed-off-by: xinhui pan <xinhui.pan@....com>

Reviewed-by: Christian König <christian.koenig@....com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> index 5766d20f29d8..e99f68af2bf7 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> @@ -1308,7 +1308,8 @@ void amdgpu_bo_release_notify(struct ttm_buffer_object *bo)
>   		amdgpu_amdkfd_unreserve_memory_limit(abo);
>   
>   	/* We only remove the fence if the resv has individualized. */
> -	WARN_ON_ONCE(bo->base.resv != &bo->base._resv);
> +	WARN_ON_ONCE(bo->type == ttm_bo_type_kernel
> +			&& bo->base.resv != &bo->base._resv);
>   	if (bo->base.resv == &bo->base._resv)
>   		amdgpu_amdkfd_remove_fence_on_pt_pd_bos(abo);
>