linux-kernel - Re: [PATCH] drm/amdgpu: Correct the condition of warning while bo release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PSXP216MB0438A4A1EFC2F67579542BB480FE0@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
Date:   Mon, 9 Mar 2020 16:03:28 +0000
From:   Nicholas Johnson <nicholas.johnson-opensource@...look.com.au>
To:     Christian König <christian.koenig@....com>
CC:     xinhui pan <xinhui.pan@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Felix.Kuehling@....com" <Felix.Kuehling@....com>,
        "Alexander.Deucher@....com" <Alexander.Deucher@....com>
Subject: Re: [PATCH] drm/amdgpu: Correct the condition of warning while bo
 release

On Mon, Mar 09, 2020 at 03:45:04PM +0100, Christian König wrote:
> Am 09.03.20 um 15:34 schrieb xinhui pan:
> > Only kernel bo has kfd eviction fence.
> > This warning is to give a notice that kfd only remove eviction fence on
> > individual bos.
> > 
> > Signed-off-by: xinhui pan <xinhui.pan@....com>
> 
> Reviewed-by: Christian König <christian.koenig@....com>
If applicable (I reported but was not the first to report / you were 
already aware):

Tested-by: Nicholas Johnson <nicholas.johnson-opensource@...look.com.au>

The warning went away when applied.

Cheers!
> 
> > ---
> >   drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> > index 5766d20f29d8..e99f68af2bf7 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> > @@ -1308,7 +1308,8 @@ void amdgpu_bo_release_notify(struct ttm_buffer_object *bo)
> >   		amdgpu_amdkfd_unreserve_memory_limit(abo);
> >   	/* We only remove the fence if the resv has individualized. */
> > -	WARN_ON_ONCE(bo->base.resv != &bo->base._resv);
> > +	WARN_ON_ONCE(bo->type == ttm_bo_type_kernel
> > +			&& bo->base.resv != &bo->base._resv);
> >   	if (bo->base.resv == &bo->base._resv)
> >   		amdgpu_amdkfd_remove_fence_on_pt_pd_bos(abo);
>