linux-kernel - Re: [PATCH v9 3/3] edac: Add support for Amazon's Annapurna Labs L2 EDAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200310134713.n4gtrgtjdjymmgm5@rric.localdomain>
Date:   Tue, 10 Mar 2020 14:47:13 +0100
From:   Robert Richter <rrichter@...vell.com>
To:     Hanna Hawa <hhhawa@...zon.com>
CC:     <bp@...en8.de>, <mchehab@...nel.org>, <tony.luck@...el.com>,
        <james.morse@....com>, <robh+dt@...nel.org>,
        <frowand.list@...il.com>, <davem@...emloft.net>,
        <gregkh@...uxfoundation.org>, <Jonathan.Cameron@...wei.com>,
        <arnd@...db.de>, <linux-kernel@...r.kernel.org>,
        <linux-edac@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <dwmw@...zon.co.uk>, <benh@...zon.com>, <ronenk@...zon.com>,
        <talel@...zon.com>, <jonnyc@...zon.com>, <hanochu@...zon.com>,
        <barakw@...zon.com>
Subject: Re: [PATCH v9 3/3] edac: Add support for Amazon's Annapurna Labs L2
 EDAC

On 29.01.20 21:50:16, Hanna Hawa wrote:
> Adds support for Amazon's Annapurna Labs L2 EDAC driver to detect and
> report L2 errors.
> 
> Signed-off-by: Hanna Hawa <hhhawa@...zon.com>
> ---
>  MAINTAINERS               |   5 +
>  drivers/edac/Kconfig      |   8 ++
>  drivers/edac/Makefile     |   1 +
>  drivers/edac/al_l2_edac.c | 270 ++++++++++++++++++++++++++++++++++++++
>  4 files changed, 284 insertions(+)
>  create mode 100644 drivers/edac/al_l2_edac.c

Hanna, most of the review comments by Boris for patch #1 (al_l1_edac)
apply here too. Please address them.

Thanks,

-Robert