[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200310094159.GG1987@ninjato>
Date: Tue, 10 Mar 2020 10:42:00 +0100
From: Wolfram Sang <wsa@...-dreams.de>
To: Stephen Boyd <swboyd@...omium.org>
Cc: linux-kernel@...r.kernel.org, Andy Gross <agross@...nel.org>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
linux-i2c@...r.kernel.org, linux-arm-msm@...r.kernel.org,
Girish Mahadevan <girishm@...eaurora.org>,
Dilip Kota <dkota@...eaurora.org>,
Alok Chauhan <alokc@...eaurora.org>,
Douglas Anderson <dianders@...omium.org>
Subject: Re: [PATCH 1/3] i2c: qcom-geni: Let firmware specify irq trigger
flags
On Tue, Feb 04, 2020 at 11:31:50AM -0800, Stephen Boyd wrote:
> We don't need to force IRQF_TRIGGER_HIGH here as the DT or ACPI tables
> should take care of this for us. Just use 0 instead so that we use the
> flags from the firmware. Also, remove specify dev_name() for the irq
> name so that we can get better information in /proc/interrupts about
> which device is generating interrupts.
>
> Cc: Girish Mahadevan <girishm@...eaurora.org>
> Cc: Dilip Kota <dkota@...eaurora.org>
> Cc: Alok Chauhan <alokc@...eaurora.org>
> Cc: Douglas Anderson <dianders@...omium.org>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
All patches look good, but this one doesn't build because dev is defined
in the next patch only. I also can't apply patch 2 before 1, so please
rebase and resend.
> ---
> drivers/i2c/busses/i2c-qcom-geni.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
> index 17abf60c94ae..3e13b54ce3f8 100644
> --- a/drivers/i2c/busses/i2c-qcom-geni.c
> +++ b/drivers/i2c/busses/i2c-qcom-geni.c
> @@ -549,8 +549,8 @@ static int geni_i2c_probe(struct platform_device *pdev)
> init_completion(&gi2c->done);
> spin_lock_init(&gi2c->lock);
> platform_set_drvdata(pdev, gi2c);
> - ret = devm_request_irq(&pdev->dev, gi2c->irq, geni_i2c_irq,
> - IRQF_TRIGGER_HIGH, "i2c_geni", gi2c);
> + ret = devm_request_irq(dev, gi2c->irq, geni_i2c_irq, 0,
> + dev_name(&pdev->dev), gi2c);
> if (ret) {
> dev_err(&pdev->dev, "Request_irq failed:%d: err:%d\n",
> gi2c->irq, ret);
> --
> Sent by a computer, using git, on the internet
>
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists