linux-kernel - Re: [PATCH] ALSA: hda/realtek: Fix pop noise on ALC225

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5ho8t39yaz.wl-tiwai@suse.de>
Date:   Wed, 11 Mar 2020 07:54:12 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     <tiwai@...e.com>, <alsa-devel@...a-project.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: hda/realtek: Fix pop noise on ALC225

On Wed, 11 Mar 2020 07:13:28 +0100,
Kai-Heng Feng wrote:
> 
> Commit 317d9313925c ("ALSA: hda/realtek - Set default power save node to
> 0") makes the ALC225 have pop noise on S3 resume and cold boot.
> 
> So partially revert this commit for ALC225 to fix the regression.
> 
> Fixes: 317d9313925c ("ALSA: hda/realtek - Set default power save node to 0")
> BugLink: https://bugs.launchpad.net/bugs/1866357
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>
> ---

Hrm, it's rather surprising.  The power_save_node was thought to be a
cause of the pop noise, but in this case it fixes.  It's interesting
because this codec chip has no loopback mixer, and the connection is
directly from DAC to pin, so in theory, it shouldn't be influenced
from other nodes.

Anyways, a slight concern is that this might cause a regression on
another machine.  But who knows, maybe the influence is very limited.
Let's apply it and see what happens.

thanks,

Takashi