linux-kernel - [PATCH] pid:fix a return value in alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1583914756-45674-1-git-send-email-tangbin@cmss.chinamobile.com>
Date:   Wed, 11 Mar 2020 16:19:16 +0800
From:   tangbin <tangbin@...s.chinamobile.com>
To:     christian.brauner@...ntu.com
Cc:     oleg@...hat.com, akpm@...ux-foundation.org,
        linux-kernel@...r.kernel.org,
        tangbin <tangbin@...s.chinamobile.com>
Subject: [PATCH] pid:fix a return value in alloc_pid

When I doing a make about linux-next in X86 right now,it prompts a 
warning about "‘retval’ may be used uninitialized in this function
[-Wmaybe-uninitialized]". So I found that undefined 'retval' initially
in alloc_pid(),so the return ERR_PTR(retval) was an uncertain value.
Kmem_cache_alloc() is for sapce,so it will return ERR_PTR(-ENOMEM) if 
unsuccessful.

Signed-off-by: tangbin <tangbin@...s.chinamobile.com>
---
 kernel/pid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/pid.c b/kernel/pid.c
index ff6cd67..f214094 100644
--- a/kernel/pid.c
+++ b/kernel/pid.c
@@ -177,7 +177,7 @@ struct pid *alloc_pid(struct pid_namespace *ns, pid_t *set_tid,
 
 	pid = kmem_cache_alloc(ns->pid_cachep, GFP_KERNEL);
 	if (!pid)
-		return ERR_PTR(retval);
+		return ERR_PTR(-ENOMEM);
 
 	tmp = ns;
 	pid->level = ns->level;
-- 
2.7.4