linux-kernel - Re: [PATCH] pid:fix a return value in alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AB48A556-E570-42B7-A7C2-5CCEA7AD6696@ubuntu.com>
Date:   Wed, 11 Mar 2020 10:12:48 +0100
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     tangbin <tangbin@...s.chinamobile.com>
CC:     oleg@...hat.com, akpm@...ux-foundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pid:fix a return value in alloc_pid

On March 11, 2020 9:19:16 AM GMT+01:00, tangbin <tangbin@...s.chinamobile.com> wrote:
>When I doing a make about linux-next in X86 right now,it prompts a 
>warning about "‘retval’ may be used uninitialized in this function
>[-Wmaybe-uninitialized]". So I found that undefined 'retval' initially
>in alloc_pid(),so the return ERR_PTR(retval) was an uncertain value.
>Kmem_cache_alloc() is for sapce,so it will return ERR_PTR(-ENOMEM) if 
>unsuccessful.
>
>Signed-off-by: tangbin <tangbin@...s.chinamobile.com>
>---
> kernel/pid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/kernel/pid.c b/kernel/pid.c
>index ff6cd67..f214094 100644
>--- a/kernel/pid.c
>+++ b/kernel/pid.c
>@@ -177,7 +177,7 @@ struct pid *alloc_pid(struct pid_namespace *ns,
>pid_t *set_tid,
> 
> 	pid = kmem_cache_alloc(ns->pid_cachep, GFP_KERNEL);
> 	if (!pid)
>-		return ERR_PTR(retval);
>+		return ERR_PTR(-ENOMEM);
> 
> 	tmp = ns;
> 	pid->level = ns->level;

There's already a fixed version in my tree for this.
https://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git/commit/?h=fixes&id=10dab84caf400f2f5f8b010ebb0c7c4272ec5093

Thanks!
Christian