linux-kernel - Re: [PATCH net-next v2 13/15] ethtool: provide channel counts with CHANNELS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200312135106.6868009e@kicinski-fedora-PC1C0HJN>
Date:   Thu, 12 Mar 2020 13:51:06 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        Jiri Pirko <jiri@...nulli.us>, Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        John Linville <linville@...driver.com>,
        Johannes Berg <johannes@...solutions.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 13/15] ethtool: provide channel counts with
 CHANNELS_GET request

On Thu, 12 Mar 2020 21:08:38 +0100 (CET) Michal Kubecek wrote:
> Implement CHANNELS_GET request to get channel counts of a network device.
> These are traditionally available via ETHTOOL_GCHANNELS ioctl request.
> 
> Omit attributes for channel types which are not supported by driver or
> device (zero reported for maximum).
> 
> v2: (all suggested by Jakub Kicinski)
>   - minor cleanup in channels_prepare_data()
>   - more descriptive channels_reply_size()
>   - omit attributes with zero max count
> 
> Signed-off-by: Michal Kubecek <mkubecek@...e.cz>

Reviewed-by: Jakub Kicinski <kuba@...nel.org>