linux-kernel - Re: [PATCH net-next v2 14/15] ethtool: set device channel counts with CHANNELS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200312135429.1a507199@kicinski-fedora-PC1C0HJN>
Date:   Thu, 12 Mar 2020 13:54:29 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        Jiri Pirko <jiri@...nulli.us>, Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        John Linville <linville@...driver.com>,
        Johannes Berg <johannes@...solutions.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 14/15] ethtool: set device channel counts
 with CHANNELS_SET request

On Thu, 12 Mar 2020 21:08:43 +0100 (CET) Michal Kubecek wrote:
> Implement CHANNELS_SET netlink request to set channel counts of a network
> device. These are traditionally set with ETHTOOL_SCHANNELS ioctl request.
> 
> Like the ioctl implementation, the generic ethtool code checks if supplied
> values do not exceed driver defined limits; if they do, first offending
> attribute is reported using extack. Checks preventing removing channels
> used for RX indirection table or zerocopy AF_XDP socket are also
> implemented.
> 
> Move ethtool_get_max_rxfh_channel() helper into common.c so that it can be
> used by both ioctl and netlink code.
> 
> v2:
>   - fix netdev reference leak in error path (found by Jakub Kicinsky)
> 
> Signed-off-by: Michal Kubecek <mkubecek@...e.cz>

Reviewed-by: Jakub Kicinski <kuba@...nel.org>

Thanks!