linux-kernel - Re: [PATCH net-next v2 00/15] ethtool netlink interface, part 3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200312.153252.145444897248947088.davem@davemloft.net>
Date:   Thu, 12 Mar 2020 15:32:52 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     mkubecek@...e.cz
Cc:     kuba@...nel.org, netdev@...r.kernel.org, jiri@...nulli.us,
        andrew@...n.ch, f.fainelli@...il.com, linville@...driver.com,
        johannes@...solutions.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 00/15] ethtool netlink interface, part 3

From: Michal Kubecek <mkubecek@...e.cz>
Date: Thu, 12 Mar 2020 21:07:33 +0100 (CET)

> Implementation of more netlink request types:
> 
>   - netdev features (ethtool -k/-K, patches 3-6)
>   - private flags (--show-priv-flags / --set-priv-flags, patches 7-9)
>   - ring sizes (ethtool -g/-G, patches 10-12)
>   - channel counts (ethtool -l/-L, patches 13-15)
> 
> Patch 1 is a style cleanup suggested in part 2 review and patch 2 updates
> the mapping between netdev features and legacy ioctl requests (which are
> still used by ethtool for backward compatibility).
> 
> Changes in v2:
>   - fix netdev reference leaks in error path of ethnl_set_rings() and
>     ethnl_set_channels() (found by Jakub Kicinski)
>   - use __set_bit() rather than set_bit() (suggested by David Miller)
>   - in replies to RINGS_GET and CHANNELS_GET requests, omit ring and
>     channel types not supported by driver/device (suggested by Jakub
>     Kicinski)
>   - more descriptive message size calculations in rings_reply_size() and
>     channels_reply_size() (suggested by Jakub Kicinski)
>   - coding style cleanup (suggested by Jakub Kicinski)

Series applied, thanks Michal.