linux-kernel - Re: [RESEND PATCH 3/5] musb: sunxi: add support for the suniv MUSB controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGb2v65LJUT1teBna7deKP7AfboUBcQDmiDgu3hrQY_+UzU0DA@mail.gmail.com>
Date:   Thu, 12 Mar 2020 14:55:52 +0800
From:   Chen-Yu Tsai <wens@...e.org>
To:     George Hilliard <thirtythreeforty@...il.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Icenowy Zheng <icenowy@...c.io>,
        linux-usb <linux-usb@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH 3/5] musb: sunxi: add support for the suniv MUSB controller

On Tue, Mar 10, 2020 at 4:44 AM George Hilliard
<thirtythreeforty@...il.com> wrote:
>
> The suniv SoC has a MUSB controller like the one in A33, but with a SRAM
> region to be claimed.
>
> Add support for it.
>
> Signed-off-by: Icenowy Zheng <icenowy@...c.io>

Same thing about the SoB and author.

> Signed-off-by: George Hilliard <thirtythreeforty@...il.com>
> ---
>  drivers/usb/musb/sunxi.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/musb/sunxi.c b/drivers/usb/musb/sunxi.c
> index f3f76f2ac63f..76806b781844 100644
> --- a/drivers/usb/musb/sunxi.c
> +++ b/drivers/usb/musb/sunxi.c
> @@ -714,14 +714,17 @@ static int sunxi_musb_probe(struct platform_device *pdev)
>         INIT_WORK(&glue->work, sunxi_musb_work);
>         glue->host_nb.notifier_call = sunxi_musb_host_notifier;
>
> -       if (of_device_is_compatible(np, "allwinner,sun4i-a10-musb"))
> +       if (of_device_is_compatible(np, "allwinner,sun4i-a10-musb") ||
> +           of_device_is_compatible(np, "allwinner,suniv-f1c100s-musb")) {
>                 set_bit(SUNXI_MUSB_FL_HAS_SRAM, &glue->flags);
> +       }
>
>         if (of_device_is_compatible(np, "allwinner,sun6i-a31-musb"))
>                 set_bit(SUNXI_MUSB_FL_HAS_RESET, &glue->flags);
>
>         if (of_device_is_compatible(np, "allwinner,sun8i-a33-musb") ||
> -           of_device_is_compatible(np, "allwinner,sun8i-h3-musb")) {
> +           of_device_is_compatible(np, "allwinner,sun8i-h3-musb") ||
> +           of_device_is_compatible(np, "allwinner,suniv-f1c100s-musb")) {
>                 set_bit(SUNXI_MUSB_FL_HAS_RESET, &glue->flags);
>                 set_bit(SUNXI_MUSB_FL_NO_CONFIGDATA, &glue->flags);
>         }
> @@ -814,6 +817,7 @@ static int sunxi_musb_remove(struct platform_device *pdev)
>  }
>
>  static const struct of_device_id sunxi_musb_match[] = {
> +       { .compatible = "allwinner,suniv-f1c100s-musb", },

And same thing about the ordering.

Once resolved,

Acked-by: Chen-Yu Tsai <wens@...e.org>

>         { .compatible = "allwinner,sun4i-a10-musb", },
>         { .compatible = "allwinner,sun6i-a31-musb", },
>         { .compatible = "allwinner,sun8i-a33-musb", },
> --
> 2.25.0
>