linux-kernel - Re: [RESEND PATCH 2/5] phy: sun4i-usb: add support for the USB PHY on suniv SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACmrr9hSK1CzDGQ9_v6gNF7TBH65J-QAL_pwQJdKCc4ZxF_-ww@mail.gmail.com>
Date:   Thu, 12 Mar 2020 07:06:37 -0500
From:   George Hilliard <thirtythreeforty@...il.com>
To:     Chen-Yu Tsai <wens@...e.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Icenowy Zheng <icenowy@...c.io>,
        linux-usb <linux-usb@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH 2/5] phy: sun4i-usb: add support for the USB PHY on
 suniv SoC

Thanks for the review.

On Thu, Mar 12, 2020 at 1:51 AM Chen-Yu Tsai <wens@...e.org> wrote:
>
> On Tue, Mar 10, 2020 at 4:43 AM George Hilliard
> <thirtythreeforty@...il.com> wrote:
> >
> > The suniv SoC has one USB OTG port connected to a MUSB controller.
> >
> > Add support for its USB PHY.
> >
> > Signed-off-by: Icenowy Zheng <icenowy@...c.io>
>
> Not sure why Icenowy's SoB is here. If she was the original author, you
> are supposed to keep her name as the author.

So, I was unclear on the convention here.  This patch is based on her
patch, but I've modified it and rebased those modifications back into
a single change.  I'm happy to change the author field - does it need
a "Co-authored-by: myself" here?

> >
> >  static const struct of_device_id sun4i_usb_phy_of_match[] = {
> > +       { .compatible = "allwinner,suniv-f1c100s-usb-phy",
> > +         .data = &suniv_f1c100s_cfg },
> >         { .compatible = "allwinner,sun4i-a10-usb-phy", .data = &sun4i_a10_cfg },
>
> Please use the same style (and ignore checkpatch.pl on this one).

Very happy to change this, it was bugging me!

George