linux-kernel - Re: [PATCH v3 00/27] ata: optimize core code size on PATA only setups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <15a1618d-a2fe-8911-764f-0d7204895ddb@kernel.dk>
Date:   Thu, 12 Mar 2020 08:09:22 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Cc:     Michael Schmitz <schmitzmic@...il.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Christoph Hellwig <hch@....de>, linux-ide@...r.kernel.org,
        linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 00/27] ata: optimize core code size on PATA only setups

On 2/27/20 11:21 AM, Bartlomiej Zolnierkiewicz wrote:
> Hi,
> 
> There have been reports in the past of libata core code size
> being a problem in migration from deprecated IDE subsystem on
> legacy PATA only systems, i.e.:
> 
> https://lore.kernel.org/linux-ide/db2838b7-4862-785b-3a1d-3bf09811340a@gmail.com/
> 
> This patchset re-organizes libata core code to exclude SATA
> specific code from being built for PATA only setups.
> 
> The end result is up to 24% (by 23949 bytes, from 101769 bytes to
> 77820 bytes) smaller libata core code size (as measured for m68k
> arch using modified atari_defconfig) on affected setups.
> 
> I've tested this patchset using pata_falcon driver under ARAnyM
> emulator.
> 
> 
> patches #1-11 are general fixes/cleanups done in the process of
> making the patchset (there should be no inter-dependencies between
> them except patch #10 which depends on patch #9)
> 
> patch #12 separates PATA timings code to libata-pata-timings.c file
> 
> patches #13-15 let compiler optimize out SATA specific code on
> non-SATA hosts by adding !IS_ENABLED(CONFIG_SATA_HOST) instances
> 
> patches #16-22 separate SATA only code from libata-core.c file to
> libata-sata.c one
> 
> patches #23-24 separate SATA only code from libata-scsi.c file to
> libata-sata.c one
> 
> patches #25-26 separate SATA only code from libata-eh.c file to
> libata-sata.c one
> 
> patch #27 makes "libata.force" kernel parameter optional

Bart, patch #2 seemed to have an issue, are you going to resend
this patchset?

-- 
Jens Axboe