[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CADnq5_NA+9VhVUGxPcJ8swu=qqPpPA+3-HK9fy5jAg5ko8TfwA@mail.gmail.com>
Date: Thu, 12 Mar 2020 10:10:14 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: Joe Perches <joe@...ches.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Leo Li <sunpeng.li@....com>,
amd-gfx list <amd-gfx@...ts.freedesktop.org>,
David Airlie <airlied@...ux.ie>,
Maling list - DRI developers
<dri-devel@...ts.freedesktop.org>,
Alex Deucher <alexander.deucher@....com>,
Christian König <christian.koenig@....com>
Subject: Re: [PATCH -next 024/491] AMD DISPLAY CORE: Use fallthrough;
Applied. thanks! (link fixed locally).
Alex
On Wed, Mar 11, 2020 at 1:07 AM Joe Perches <joe@...ches.com> wrote:
>
> Convert the various uses of fallthrough comments to fallthrough;
>
> Done via script
> Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/
>
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
> drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 4 ++--
> drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 2 +-
> drivers/gpu/drm/amd/display/dc/dce/dce_mem_input.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c b/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
> index 2f1c958..37fa7b 100644
> --- a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
> +++ b/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
> @@ -267,7 +267,7 @@ static struct atom_display_object_path_v2 *get_bios_object(
> && id.enum_id == obj_id.enum_id)
> return &bp->object_info_tbl.v1_4->display_path[i];
> }
> - /* fall through */
> + fallthrough;
> case OBJECT_TYPE_CONNECTOR:
> case OBJECT_TYPE_GENERIC:
> /* Both Generic and Connector Object ID
> @@ -280,7 +280,7 @@ static struct atom_display_object_path_v2 *get_bios_object(
> && id.enum_id == obj_id.enum_id)
> return &bp->object_info_tbl.v1_4->display_path[i];
> }
> - /* fall through */
> + fallthrough;
> default:
> return NULL;
> }
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c b/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
> index 68c4049..743042 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
> @@ -645,7 +645,7 @@ bool dce_aux_transfer_with_retries(struct ddc_service *ddc,
> case AUX_TRANSACTION_REPLY_AUX_DEFER:
> case AUX_TRANSACTION_REPLY_I2C_OVER_AUX_DEFER:
> retry_on_defer = true;
> - /* fall through */
> + fallthrough;
> case AUX_TRANSACTION_REPLY_I2C_OVER_AUX_NACK:
> if (++aux_defer_retries >= AUX_MAX_DEFER_RETRIES) {
> goto fail;
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_mem_input.c b/drivers/gpu/drm/amd/display/dc/dce/dce_mem_input.c
> index 8aa937f..51481e 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_mem_input.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_mem_input.c
> @@ -479,7 +479,7 @@ static void program_grph_pixel_format(
> case SURFACE_PIXEL_FORMAT_GRPH_ABGR16161616F:
> sign = 1;
> floating = 1;
> - /* fall through */
> + fallthrough;
> case SURFACE_PIXEL_FORMAT_GRPH_ARGB16161616F: /* shouldn't this get float too? */
> case SURFACE_PIXEL_FORMAT_GRPH_ARGB16161616:
> grph_depth = 3;
> --
> 2.24.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Powered by blists - more mailing lists