linux-kernel - R: [PATCH] ARM: qcom: Disable i2c device on gsbi4 for ipq806x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 13 Mar 2020 23:34:05 +0100
From:   <ansuelsmth@...il.com>
To:     "'Stephen Boyd'" <sboyd@...nel.org>, <agross@...nel.org>
Cc:     "'Mathieu Olivari'" <mathieu@...eaurora.org>,
        "'Bjorn Andersson'" <bjorn.andersson@...aro.org>,
        "'Rob Herring'" <robh+dt@...nel.org>,
        "'Mark Rutland'" <mark.rutland@....com>,
        "'Michael Turquette'" <mturquette@...libre.com>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-clk@...r.kernel.org>
Subject: R: [PATCH] ARM: qcom: Disable i2c device on gsbi4 for ipq806x

> Quoting Ansuel Smith (2020-03-13 12:58:16)
> > diff --git a/arch/arm/boot/dts/qcom-ipq8064-ap148.dts
> b/arch/arm/boot/dts/qcom-ipq8064-ap148.dts
> > index 554c65e7aa0e..580aec63030d 100644
> > --- a/arch/arm/boot/dts/qcom-ipq8064-ap148.dts
> > +++ b/arch/arm/boot/dts/qcom-ipq8064-ap148.dts
> > @@ -21,14 +21,5 @@ mux {
> >                                 };
> >                         };
> >                 };
> > -
> > -               gsbi@...00000 {
> > -                       i2c@...80000 {
> > -                               status = "ok";
> > -                               clock-frequency = <200000>;
> > -                               pinctrl-0 = <&i2c4_pins>;
> > -                               pinctrl-names = "default";
> > -                       };
> > -               };
> >         };
> >  };
> > diff --git a/drivers/clk/qcom/gcc-ipq806x.c b/drivers/clk/qcom/gcc-
> ipq806x.c
> > index b0eee0903807..75706807e6cf 100644
> > --- a/drivers/clk/qcom/gcc-ipq806x.c
> > +++ b/drivers/clk/qcom/gcc-ipq806x.c
> > @@ -782,7 +782,7 @@ static struct clk_rcg gsbi4_qup_src = {
> >                         .parent_names = gcc_pxo_pll8,
> >                         .num_parents = 2,
> >                         .ops = &clk_rcg_ops,
> > -                       .flags = CLK_SET_PARENT_GATE,
> > +                       .flags = CLK_SET_PARENT_GATE | CLK_IGNORE_UNUSED,
> 
> A better solution is to use the protected-clocks property so we don't
> try to touch these clks at all on this device. So this whole patch can
> be routed through arm-soc and remove the i2c node and add some dt
> property to the gcc node.
> 

Should I add a comment where the i2c is removed or I can remove it
directly?

> >                 },
> >         },
> >  };