linux-kernel - Re: linux-next: build failure after merge of the v4l-dvb tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200313071423.c4t3onkft4r66hav@pengutronix.de>
Date:   Fri, 13 Mar 2020 08:14:24 +0100
From:   Marco Felsch <m.felsch@...gutronix.de>
To:     Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Hans Verkuil <hverkuil-cisco@...all.nl>
Subject: Re: linux-next: build failure after merge of the v4l-dvb tree

On 20-03-13 08:05, Mauro Carvalho Chehab wrote:
> Em Fri, 13 Mar 2020 07:48:07 +0100
> Marco Felsch <m.felsch@...gutronix.de> escreveu:
> 
> > Hi Stephen,
> > 
> > On 20-03-13 13:19, Stephen Rothwell wrote:
> > > Hi all,
> > > 
> > > After merging the v4l-dvb tree, today's linux-next build (arm
> > > multi_v7_defconfig) failed like this:
> > > 
> > > ERROR: modpost: "fwnode_get_name" [drivers/media/v4l2-core/v4l2-fwnode.ko] undefined!
> > > 
> > > Caused by commit
> > > 
> > >   dfc22c073b78 ("media: v4l2-fwnode: add initial connector parsing support")
> > > 
> > > I have used the v4l-dvb tree from next-20200312 for today.  
> > 
> > I'm sorry for that. I put my branch on our 0day to test most of the
> > compile configs. Obviously this casae wasn't covered..
> > 
> > @Sakari
> > I will send a patch to fix this by adding:
> > EXPORT_SYMBOL_GPL(fwnode_get_name).
> 
> There is already such patch at next-20200312:

You're right. This answers my question why I got no build errors..

Regards,
  Marco

> $ git show a7914d1072fb8ddeb2ec87bba1d28812483a3565
> commit a7914d1072fb8ddeb2ec87bba1d28812483a3565
> Author: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> Date:   Mon Mar 2 16:53:51 2020 +0300
> 
>     device property: Export fwnode_get_name()
>     
>     This makes it possible to take advantage of the function in
>     the device drivers.
>     
>     Signed-off-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
>     Acked-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
>     Link: https://lore.kernel.org/r/20200302135353.56659-8-heikki.krogerus@linux.intel.com
>     Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> diff --git a/drivers/base/property.c b/drivers/base/property.c
> index 511f6d7acdfe..5f35c0ccf5e0 100644
> --- a/drivers/base/property.c
> +++ b/drivers/base/property.c
> @@ -566,6 +566,7 @@ const char *fwnode_get_name(const struct fwnode_handle *fwnode)
>  {
>         return fwnode_call_ptr_op(fwnode, get_name);
>  }
> +EXPORT_SYMBOL_GPL(fwnode_get_name);
>  
>  /**
>   * fwnode_get_name_prefix - Return the prefix of node for printing purposes
> 
> 
> 
> 
> Thanks,
> Mauro