linux-kernel - Re: [PATCH net-next v2 2/3] net: phy: mscc: split the driver into separate files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <158408684876.668992.7957856749031634535@kwain>
Date:   Fri, 13 Mar 2020 09:07:29 +0100
From:   Antoine Tenart <antoine.tenart@...tlin.com>
To:     David Miller <davem@...emloft.net>
Cc:     andrew@...n.ch, f.fainelli@...il.com, hkallweit1@...il.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 2/3] net: phy: mscc: split the driver into separate files

Hello David,

Quoting David Miller (2020-03-12 23:43:36)
> From: Antoine Tenart <antoine.tenart@...tlin.com>
> Date: Thu, 12 Mar 2020 23:10:32 +0100
> 
> > +inline int vsc8584_macsec_init(struct phy_device *phydev)
> > +{
> > +     return 0;
> > +}
> > +inline void vsc8584_handle_macsec_interrupt(struct phy_device *phydev)
> > +{
> > +}
> > +inline void vsc8584_config_macsec_intr(struct phy_device *phydev)
> > +{
> > +}
> 
> Please use "static inline", as otherwise if this file is included multiple times it
> will cause the compiler to emit potentially two uninlined copies which will result
> in a linking error.

Will do.

Thanks!
Antoine

-- 
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com