linux-kernel - Re: [PATCH 05/16] soundwire: cadence: add clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200313122156.GG4885@vkoul-mobl>
Date:   Fri, 13 Mar 2020 17:51:56 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
Cc:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        tiwai@...e.de, broonie@...nel.org, gregkh@...uxfoundation.org,
        jank@...ence.com, srinivas.kandagatla@...aro.org,
        slawomir.blauciak@...el.com,
        Bard liao <yung-chuan.liao@...ux.intel.com>,
        Rander Wang <rander.wang@...ux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Hui Wang <hui.wang@...onical.com>,
        Rander Wang <rander.wang@...el.com>,
        Sanyog Kale <sanyog.r.kale@...el.com>
Subject: Re: [PATCH 05/16] soundwire: cadence: add clock_stop/restart routines

On 11-03-20, 13:41, Pierre-Louis Bossart wrote:

> @@ -225,12 +225,30 @@ static int cdns_clear_bit(struct sdw_cdns *cdns, int offset, u32 value)
>  			return 0;
>  
>  		timeout--;
> -		udelay(50);
> +		usleep_range(50, 100);

this seems okay change, but unrelated to this patch

> +int sdw_cdns_clock_stop(struct sdw_cdns *cdns, bool block_wake)
> +{
> +	bool slave_present = false;
> +	struct sdw_slave *slave;
> +	u32 status;
> +	int ret;
> +
> +	/* Check suspend status */
> +	status = cdns_readl(cdns, CDNS_MCP_STAT);
> +	if (status & CDNS_MCP_STAT_CLK_STOP) {
> +		dev_dbg(cdns->dev, "Clock is already stopped\n");
> +		return 1;

return of 1..? Does that indicate success/fail..?

-- 
~Vinod