linux-kernel - Re: [for-next PATCH v2 1/5] phy: ti: gmii-sel: simplify config dependencies between net drivers and gmii phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34c01cc2-55ed-8160-45eb-b75ca768bfb0@ti.com>
Date:   Fri, 13 Mar 2020 17:07:43 +0200
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     Kishon Vijay Abraham I <kishon@...com>,
        Murali Karicheri <m-karicheri2@...com>,
        Tero Kristo <t-kristo@...com>,
        "David S . Miller" <davem@...emloft.net>
CC:     Sekhar Nori <nsekhar@...com>, Rob Herring <robh+dt@...nel.org>,
        netdev <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [for-next PATCH v2 1/5] phy: ti: gmii-sel: simplify config
 dependencies between net drivers and gmii phy

Hi All,

On 05/03/2020 13:06, Kishon Vijay Abraham I wrote:
> Hi Dave,
> 
> On 03/03/20 9:30 pm, Grygorii Strashko wrote:
>> The phy-gmii-sel can be only auto selected in Kconfig and now the pretty
>> complex Kconfig dependencies are defined for phy-gmii-sel driver, which
>> also need to be updated every time phy-gmii-sel is re-used for any new
>> networking driver.
>>
>> Simplify Kconfig definition for phy-gmii-sel PHY driver - drop all
>> dependencies and from networking drivers and rely on using 'imply
>> PHY_TI_GMII_SEL' in Kconfig definitions for networking drivers instead.
>>
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>
>> ---
>>   drivers/net/ethernet/ti/Kconfig | 1 +
> 
> I can pick this in my tree. Can you give your Acked-by since there is a
> small change in drivers/net?

Sorry for disturbing you, but what's the final decision here?



> 
> Thanks
> Kishon
>>   drivers/phy/ti/Kconfig          | 3 ---
>>   2 files changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
>> index bf98e0fa7d8b..8a6ca16eee3b 100644
>> --- a/drivers/net/ethernet/ti/Kconfig
>> +++ b/drivers/net/ethernet/ti/Kconfig
>> @@ -53,6 +53,7 @@ config TI_CPSW
>>   	select MFD_SYSCON
>>   	select PAGE_POOL
>>   	select REGMAP
>> +	imply PHY_TI_GMII_SEL
>>   	---help---
>>   	  This driver supports TI's CPSW Ethernet Switch.
>>   
>> diff --git a/drivers/phy/ti/Kconfig b/drivers/phy/ti/Kconfig
>> index 6dbe9d0b9ff3..15a3bcf32308 100644
>> --- a/drivers/phy/ti/Kconfig
>> +++ b/drivers/phy/ti/Kconfig
>> @@ -106,11 +106,8 @@ config TWL4030_USB
>>   
>>   config PHY_TI_GMII_SEL
>>   	tristate
>> -	default y if TI_CPSW=y || TI_CPSW_SWITCHDEV=y
>> -	depends on TI_CPSW || TI_CPSW_SWITCHDEV || COMPILE_TEST
>>   	select GENERIC_PHY
>>   	select REGMAP
>> -	default m
>>   	help
>>   	  This driver supports configuring of the TI CPSW Port mode depending on
>>   	  the Ethernet PHY connected to the CPSW Port.
>>

-- 
Best regards,
grygorii