linux-kernel - Re: [PATCH] gpio: mvebu: avoid error message for optional IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMpxmJVmspJG9tnv7tTrCP4DA5v4H_3P_4n-O-ZHkOKXgtXhLQ@mail.gmail.com>
Date:   Fri, 13 Mar 2020 16:07:49 +0100
From:   Bartosz Golaszewski <bgolaszewski@...libre.com>
To:     Chris Packham <chris.packham@...iedtelesis.co.nz>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-pwm@...r.kernel.org, linux-gpio <linux-gpio@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: mvebu: avoid error message for optional IRQ

pt., 13 mar 2020 o 04:42 Chris Packham
<chris.packham@...iedtelesis.co.nz> napisał(a):
>
> platform_get_irq() will generate an error message if the requested irq
> is not present
>
>   mvebu-gpio f1010140.gpio: IRQ index 3 not found
>
> use platform_get_irq_optional() to avoid the error message being
> generated.
>
> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
> ---
>  drivers/gpio/gpio-mvebu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c
> index d2b999c7987f..3c9f4fb3d5a2 100644
> --- a/drivers/gpio/gpio-mvebu.c
> +++ b/drivers/gpio/gpio-mvebu.c
> @@ -1247,7 +1247,7 @@ static int mvebu_gpio_probe(struct platform_device *pdev)
>          * pins.
>          */
>         for (i = 0; i < 4; i++) {
> -               int irq = platform_get_irq(pdev, i);
> +               int irq = platform_get_irq_optional(pdev, i);
>
>                 if (irq < 0)
>                         continue;
> --
> 2.25.1
>

Patch applied, thanks!

Bartosz