linux-kernel - Re: [PATCH 0/4] gpio: dwapb: Fix reference clocks usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200313152928.54lk2wi42auh2nat@ubsrv2.baikal.int>
Date:   Fri, 13 Mar 2020 18:29:28 +0300
From:   Sergey Semin <Sergey.Semin@...kalelectronics.ru>
To:     Linus Walleij <linus.walleij@...aro.org>
CC:     Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>,
        Maxim Kaurkin <Maxim.Kaurkin@...kalelectronics.ru>,
        Pavel Parkhomenko <Pavel.Parkhomenko@...kalelectronics.ru>,
        Ramil Zaripov <Ramil.Zaripov@...kalelectronics.ru>,
        Ekaterina Skachko <Ekaterina.Skachko@...kalelectronics.ru>,
        Vadim Vlasov <V.Vlasov@...kalelectronics.ru>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Paul Burton <paulburton@...nel.org>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Hoan Tran <hoan@...amperecomputing.com>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/4] gpio: dwapb: Fix reference clocks usage

On Thu, Mar 12, 2020 at 02:58:33PM +0100, Linus Walleij wrote:
> On Fri, Mar 6, 2020 at 2:25 PM <Sergey.Semin@...kalelectronics.ru> wrote:
> 
> > From: Serge Semin <fancer.lancer@...il.com>
> >
> > There is no need in any fixes to have the Baikal-T1 SoC DW GPIO controllers
> > supported by the kernel DW APB GPIO driver. It works for them just fine with
> > no modifications. But still there is a room for optimizations there.
> >
> > First of all as it tends to be traditional for all Baikal-T1 SoC related
> > patchset we replaced the legacy plain text-based dt-binding file with
> > yaml-based one. Baikal-T1 DW GPIO port A supports a debounce functionality,
> > but in order to use it the corresponding reference clock must be enabled.
> > We added support of that clock in the driver and made sure the dt-bindings
> > had its declaration. In addition seeing both APB and debounce reference
> > clocks are optional, we replaced the standard devm_clk_get() usage with
> > the function of optional clocks acquisition.
> >
> > This patchset is rebased and tested on the mainline Linux kernel 5.6-rc4:
> > commit 98d54f81e36b ("Linux 5.6-rc4").
> >
> > Signed-off-by: Serge Semin <Sergey.Semin@...kalelectronics.ru>
> > Signed-off-by: Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>
> > Cc: Maxim Kaurkin <Maxim.Kaurkin@...kalelectronics.ru>
> > Cc: Pavel Parkhomenko <Pavel.Parkhomenko@...kalelectronics.ru>
> > Cc: Ramil Zaripov <Ramil.Zaripov@...kalelectronics.ru>
> > Cc: Ekaterina Skachko <Ekaterina.Skachko@...kalelectronics.ru>
> > Cc: Vadim Vlasov <V.Vlasov@...kalelectronics.ru>
> > Cc: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
> > Cc: Paul Burton <paulburton@...nel.org>
> > Cc: Ralf Baechle <ralf@...ux-mips.org>
> > Cc: Hoan Tran <hoan@...amperecomputing.com>
> > Cc: Linus Walleij <linus.walleij@...aro.org>
> > Cc: Bartosz Golaszewski <bgolaszewski@...libre.com>
> > Cc: Philipp Zabel <p.zabel@...gutronix.de>
> > Cc: Rob Herring <robh+dt@...nel.org>
> > Cc: Mark Rutland <mark.rutland@....com>
> > Cc: linux-gpio@...r.kernel.org
> > Cc: devicetree@...r.kernel.org
> > Cc: linux-kernel@...r.kernel.org
> 
> I like these patches, once Rob is happy with the bindings I'll be
> happy to merge them. I haven't heard from Hoan Tran in a while,
> so if we don't hear from him this time either I would suggest you
> also add yourself as maintainer for this driver, if you don't mind.
> 
> Thanks,
> Linus Walleij

Hello Linus,
Thanks for positive response. I'll resend the patchset soon in the
email-threaded form together with two extra patches, which will
add me to the MAINTAINERS list and to the dt-schema of the driver.
If Hoan Tran will show up before you merge them, just drop these two
new patches.

Regards,
-Sergey