linux-kernel - Re: [PATCH v4] Documentation: kunit: Make the KUnit documentation less UML-specific

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ec2f35ef-54d2-cd67-5e30-33ce7612a6d4@kernel.org>
Date:   Fri, 13 Mar 2020 10:05:30 -0600
From:   shuah <shuah@...nel.org>
To:     Frank Rowand <frowand.list@...il.com>,
        David Gow <davidgow@...gle.com>, brendanhiggins@...gle.com,
        skhan@...uxfoundation.org, corbet@....net
Cc:     kunit-dev@...glegroups.com, linux-doc@...r.kernel.org,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        Tim.Bird@...y.com, Frank Rowand <frank.rowand@...y.com>,
        shuah <shuah@...nel.org>
Subject: Re: [PATCH v4] Documentation: kunit: Make the KUnit documentation
 less UML-specific

On 3/2/20 9:50 AM, Frank Rowand wrote:
> Hi David,
> 
> On 2/28/20 1:18 PM, David Gow wrote:
>> Remove some of the outmoded "Why KUnit" rationale, and move some
>> UML-specific information to the kunit_tool page. Also update the Getting
>> Started guide to mention running tests without the kunit_tool wrapper.
>>
>> Signed-off-by: David Gow <davidgow@...gle.com>
>> Reviewed-by: Frank Rowand <frank.rowand@...y.com>
>> ---
>> Sorry: I missed a couple of issues in the last version. They're fixed
>> here, and I think this should be ready to go.
>>
>> Changelog:
>>
>> v4:
>> - Fix typo: s/offsers/offers
>> - Talk about KUnit tests running on most "architectures" instead of
>>    "kernel configurations.
>> v3:
>> https://lore.kernel.org/linux-kselftest/20200214235723.254228-1-davidgow@google.com/T/#u
>> - Added a note that KUnit can be used with UML, both with and without
>>    kunit_tool to replace the section moved to kunit_tool.
>> v2:
>> https://lore.kernel.org/linux-kselftest/f99a3d4d-ad65-5fd1-3407-db33f378b1fa@gmail.com/T/
>> - Reinstated the "Why Kunit?" section, minus the comparison with other
>>    testing frameworks (covered in the FAQ), and the description of UML.
>> - Moved the description of UML into to kunit_tool page.
>> - Tidied up the wording around how KUnit is built and run to make it
>>    work
>>    without the UML description.
>> v1:
>> https://lore.kernel.org/linux-kselftest/9c703dea-a9e1-94e2-c12d-3cb0a09e75ac@gmail.com/T/
>> - Initial patch
> 
> Thanks for all the changes.  The documents are now much more understandable
> and useful.
> 

Is this ready to go? If it goes through doc tree:

Acked-by: Shuah Khan <skhan@...uxfoundation.org>

Otherwise, I can pic it up.

thanks,
-- Shuah