linux-kernel - [PATCH] iwlwifi: mvm: Avoid use of GEO_TX_POWER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200314105700.GM311@earth.li>
Date:   Sat, 14 Mar 2020 10:57:00 +0000
From:   Jonathan McDowell <noodles@...th.li>
To:     linux-wireless@...r.kernel.org
Cc:     Intel Linux Wireless <linuxwifi@...el.com>,
        Ihab Zhaika <ihab.zhaika@...el.com>, johannes.berg@...el.com,
        emmanuel.grumbach@...el.com, luciano.coelho@...el.com,
        linux-kernel@...r.kernel.org
Subject: [PATCH] iwlwifi: mvm: Avoid use of GEO_TX_POWER_LIMIT when not
 supported

Commit 39c1a9728f93 refactored the SAR table support and inadvertently
added a call to GEO_TX_POWER_LIMIT without checking that the firmware
supported it. This caused a regression for device + firmware
combinations lacking the support. Add a check in iwl_mvm_sar_init to
prevent this.

Fixes: 39c1a9728f93 (iwlwifi: refactor the SAR tables from mvm to acpi)
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=206395
Cc: stable@...r.kernel.org # 5.5
Signed-Off-By: Jonathan McDowell <noodles@...th.li>

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
index 54c094e88474..4a8a4cb2c553 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
@@ -1007,6 +1007,13 @@ static int iwl_mvm_sar_init(struct iwl_mvm *mvm)
 	if (ret == -ENOENT)
 		return 1;
 
+	/*
+	 * If our firmware doesn't support GEO_TX_POWER_LIMIT then skip trying
+	 * to use it.
+	 */
+	if (!iwl_sar_geo_support(&mvm->fwrt))
+		return 1;
+
 	return ret;
 }
 

-- 
... Don't do it!