linux-kernel - Re: [RFC][PATCH 05/16] objtool: Optimize find_symbol_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200315160919.zd7phtq7ejyq4kva@treble>
Date:   Sun, 15 Mar 2020 11:09:19 -0500
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     tglx@...utronix.de, linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: [RFC][PATCH 05/16] objtool: Optimize find_symbol_by_index()

On Thu, Mar 12, 2020 at 02:41:12PM +0100, Peter Zijlstra wrote:
> The symbol index is object wide, not per section, so it makes no sense
> to have the symbol_hash be part of the section object. By moving it to
> the elf object we avoid the linear sections iteration.

I remember there was a specific reason for this oddity, but it eludes me
now.

This does make sense, assuming it doesn't break anything.

-- 
Josh