linux-kernel - Re: [PATCH net-next] chcr: remove set but not used variable 'status'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 15 Mar 2020 21:39:24 +0530
From:   rohit maheshwari <rohitm@...lsio.com>
To:     YueHaibing <yuehaibing@...wei.com>, ayush.sawal@...lsio.com,
        vinay.yadav@...lsio.com, herbert@...dor.apana.org.au,
        davem@...emloft.net
Cc:     linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next] chcr: remove set but not used variable 'status'


On 14/03/20 4:21 PM, YueHaibing wrote:
> drivers/crypto/chelsio/chcr_ktls.c: In function chcr_ktls_cpl_set_tcb_rpl:
> drivers/crypto/chelsio/chcr_ktls.c:662:11: warning:
>   variable status set but not used [-Wunused-but-set-variable]
>
> commit 8a30923e1598 ("cxgb4/chcr: Save tx keys and handle HW response")
> involved this unused variable, remove it.
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>   drivers/crypto/chelsio/chcr_ktls.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/chelsio/chcr_ktls.c b/drivers/crypto/chelsio/chcr_ktls.c
> index f0c3834eda4f..00099e793e63 100644
> --- a/drivers/crypto/chelsio/chcr_ktls.c
> +++ b/drivers/crypto/chelsio/chcr_ktls.c
> @@ -659,10 +659,9 @@ int chcr_ktls_cpl_set_tcb_rpl(struct adapter *adap, unsigned char *input)
>   	const struct cpl_set_tcb_rpl *p = (void *)input;
>   	struct chcr_ktls_info *tx_info = NULL;
>   	struct tid_info *t;
> -	u32 tid, status;
> +	u32 tid;
>   
>   	tid = GET_TID(p);
> -	status = p->status;
>   
>   	t = &adap->tids;
>   	tx_info = lookup_tid(t, tid);

Thanks for fixing it. Looks good to me.