linux-kernel - Re: [RFC][PATCH 15/16] objtool: Implement noinstr validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200316192053.5oactl56lo6w7vw4@treble>
Date:   Mon, 16 Mar 2020 14:20:53 -0500
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     tglx@...utronix.de, linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: [RFC][PATCH 15/16] objtool: Implement noinstr validation

On Mon, Mar 16, 2020 at 05:48:27PM +0100, Peter Zijlstra wrote:
> On Mon, Mar 16, 2020 at 11:19:04AM -0500, Josh Poimboeuf wrote:
> > On Mon, Mar 16, 2020 at 02:24:19PM +0100, Peter Zijlstra wrote:
> > > > And "read_instr_hints" reads as "read_instruction_hints()".
> > > > 
> > > > Can we come up with a more readable name?  Why not just "notrace"?
> > > > 
> > > > The trace begin/end annotations could be
> > > > 
> > > >   trace_allow_begin()
> > > >   trace_allow_end()
> > > 
> > > notrace already exists and we didn't want to confuse things further.
> > 
> > Um, why would it confuse things to call a section of notrace code
> > ".notrace.text"???
> 
> Because it is strictly stronger than the notrace attribute is. And we
> certainly don't want all that is now marked notrace to end up there.

Ok, I must have misunderstood, I thought it was *all* notrace code going
in there.

I still hope we can come up with a better name.

-- 
Josh