linux-kernel - Re: [RFC][PATCH 15/16] objtool: Implement noinstr validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200316164827.GH12521@hirez.programming.kicks-ass.net>
Date:   Mon, 16 Mar 2020 17:48:27 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     tglx@...utronix.de, linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: [RFC][PATCH 15/16] objtool: Implement noinstr validation

On Mon, Mar 16, 2020 at 11:19:04AM -0500, Josh Poimboeuf wrote:
> On Mon, Mar 16, 2020 at 02:24:19PM +0100, Peter Zijlstra wrote:
> > > And "read_instr_hints" reads as "read_instruction_hints()".
> > > 
> > > Can we come up with a more readable name?  Why not just "notrace"?
> > > 
> > > The trace begin/end annotations could be
> > > 
> > >   trace_allow_begin()
> > >   trace_allow_end()
> > 
> > notrace already exists and we didn't want to confuse things further.
> 
> Um, why would it confuse things to call a section of notrace code
> ".notrace.text"???

Because it is strictly stronger than the notrace attribute is. And we
certainly don't want all that is now marked notrace to end up there.

Our section also very much excludes kprobes and hardware breakpoints for
starters.