linux-kernel - Re: [PATCH] KVM: X86: correct meaningless kvm_apicv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eb1037c8-fdb5-4f4c-4641-915c0e3d01bc@redhat.com>
Date:   Mon, 16 Mar 2020 17:39:36 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Sean Christopherson <sean.j.christopherson@...el.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>
Cc:     linmiaohe@...wei.com, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org
Subject: Re: [PATCH] KVM: X86: correct meaningless kvm_apicv_activated() check

On 16/03/20 16:59, Sean Christopherson wrote:
>>>
>> 	if (!!old == !!new)
>> 		return;
>>
>> to make it clear we're converting them to 1/0 :-)
>
> All I can think of now is the Onion article regarding razor blades...
> 
> 	if (!!!!old == !!!!new)
> 		return;
> 

That would be !!!!!, but seriously I'll go with two.

(Thanks for giving me a chuckle, it's sorely needed these days).

Paolo