linux-kernel - RE: [PATCH v2] EDAC: synopsys: Fix the wrong call of pinf->col parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM6PR04MB6584F064D683493842EE5B4A92F90@AM6PR04MB6584.eurprd04.prod.outlook.com>
Date:   Mon, 16 Mar 2020 12:28:58 +0000
From:   Sherry Sun <sherry.sun@....com>
To:     Borislav Petkov <bp@...en8.de>
CC:     "mchehab@...nel.org" <mchehab@...nel.org>,
        "tony.luck@...el.com" <tony.luck@...el.com>,
        "james.morse@....com" <james.morse@....com>,
        "rrichter@...vell.com" <rrichter@...vell.com>,
        "michal.simek@...inx.com" <michal.simek@...inx.com>,
        "manish.narani@...inx.com" <manish.narani@...inx.com>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>, Frank Li <frank.li@....com>
Subject: RE: [PATCH v2] EDAC: synopsys: Fix the wrong call of pinf->col
 parameter

Hi Borislav,

> -----Original Message-----
> From: Borislav Petkov <bp@...en8.de>
> Sent: 2020年3月16日 18:44
> To: Sherry Sun <sherry.sun@....com>
> Cc: mchehab@...nel.org; tony.luck@...el.com; james.morse@....com;
> rrichter@...vell.com; michal.simek@...inx.com; manish.narani@...inx.com;
> linux-edac@...r.kernel.org; linux-kernel@...r.kernel.org; dl-linux-imx
> <linux-imx@....com>; Frank Li <frank.li@....com>
> Subject: Re: [PATCH v2] EDAC: synopsys: Fix the wrong call of pinf->col
> parameter
> 
> On Mon, Mar 16, 2020 at 01:30:39AM +0000, Sherry Sun wrote:
> > Maybe you misunderstood the handle_error(), this function has already
> > distinguished between Zynq and ZynqMP through priv->p_data->quirks.
> > And what I am doing in this patch is to remove the useless pinf->col
> > in ZynqMP part, which won't break the Zynq part.
> 
> Ok, I see it now, thanks for clarifying.
> 
> Now, in your v2 pls fix this check in handle_error():
> 
> 	if (!priv->p_data->quirks) {
> 
> to *actually* *explicitly* check that the platform for which this function is
> called, really supports interrupts, i.e., DDR_ECC_INTR_SUPPORT, and not that
> the ->quirks thing is != 0. Like the rest of the code does.
> 

Ok, I will fix this check.

Best regards
Sherry Sun

> Thx.
> 
> --
> Regards/Gruss,
>     Boris.
> 
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpeopl
> e.kernel.org%2Ftglx%2Fnotes-about-
> netiquette&amp;data=02%7C01%7Csherry.sun%40nxp.com%7Ccd843239ffd
> d48a05ce408d7c996ebd5%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C
> 0%7C637199522356909838&amp;sdata=5p6JuXQQJgyjlaMOUH1cLLSDFbUzM
> R%2Fjzs5HC%2FeU1Zc%3D&amp;reserved=0