linux-kernel - Re: [PATCH v2] EDAC: synopsys: Fix the wrong call of pinf->col parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200316104356.GH26126@zn.tnic>
Date:   Mon, 16 Mar 2020 11:43:56 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Sherry Sun <sherry.sun@....com>
Cc:     "mchehab@...nel.org" <mchehab@...nel.org>,
        "tony.luck@...el.com" <tony.luck@...el.com>,
        "james.morse@....com" <james.morse@....com>,
        "rrichter@...vell.com" <rrichter@...vell.com>,
        "michal.simek@...inx.com" <michal.simek@...inx.com>,
        "manish.narani@...inx.com" <manish.narani@...inx.com>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>, Frank Li <frank.li@....com>
Subject: Re: [PATCH v2] EDAC: synopsys: Fix the wrong call of pinf->col
 parameter

On Mon, Mar 16, 2020 at 01:30:39AM +0000, Sherry Sun wrote:
> Maybe you misunderstood the handle_error(), this function has already 
> distinguished between Zynq and ZynqMP through priv->p_data->quirks.
> And what I am doing in this patch is to remove the useless pinf->col in ZynqMP
> part, which won't break the Zynq part.

Ok, I see it now, thanks for clarifying.

Now, in your v2 pls fix this check in handle_error():

	if (!priv->p_data->quirks) {

to *actually* *explicitly* check that the platform for which
this function is called, really supports interrupts, i.e.,
DDR_ECC_INTR_SUPPORT, and not that the ->quirks thing is != 0. Like the
rest of the code does.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette