linux-kernel - Re: [PATCH v2 2/2] ASoC: fsl: Add generic CPU DAI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e00e3fe1-7e87-e9c5-7c53-50ac6fa991e7@metafoo.de>
Date:   Mon, 16 Mar 2020 16:10:47 +0100
From:   Lars-Peter Clausen <lars@...afoo.de>
To:     Daniel Baluta <daniel.baluta@....nxp.com>,
        pierre-louis.bossart@...ux.intel.com, alsa-devel@...a-project.org,
        kuninori.morimoto.gx@...esas.com, peter.ujfalusi@...com,
        broonie@...nel.org, linux-imx@....com, robh+dt@...nel.org,
        devicetree@...r.kernel.org
Cc:     Xiubo.Lee@...il.com, linux-kernel@...r.kernel.org,
        shengjiu.wang@....com, tiwai@...e.com,
        ranjani.sridharan@...ux.intel.com, liam.r.girdwood@...ux.intel.com,
        Daniel Baluta <daniel.baluta@....com>,
        sound-open-firmware@...a-project.org
Subject: Re: [PATCH v2 2/2] ASoC: fsl: Add generic CPU DAI driver

On 3/6/20 12:13 PM, Daniel Baluta wrote:
> +static int fsl_dai_probe(struct platform_device *pdev)
> +{
> [...]
> +	ret = of_property_read_u32(np, "fsl,dai-index", &dai_index);
> +	if (ret) {
> +		dev_err(&pdev->dev, "dai-index missing or invalid\n");
> +		return ret;
> +	}
Maybe this can follow a more standard approach using DT aliases. Just 
like we assign IDs to things like SPI or I2C masters.
> +
> +	fsl_dai.name = dai_name;
This breaks as soon as there is more than one DAI in the system since 
you are sharing a global struct between them.
[...]