lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 16 Mar 2020 10:49:14 -0700 From: Stephen Boyd <sboyd@...nel.org> To: Michael Turquette <mturquette@...libre.com>, Taniya Das <tdas@...eaurora.org> Cc: David Brown <david.brown@...aro.org>, Rajendra Nayak <rnayak@...eaurora.org>, linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org, linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, Andy Gross <agross@...nel.org>, devicetree@...r.kernel.org, robh@...nel.org, robh+dt@...nel.org, Taniya Das <tdas@...eaurora.org> Subject: Re: [PATCH v1 1/3] clk: qcom: gcc: Add support for a new frequency for SC7180 Quoting Taniya Das (2020-03-16 03:54:40) > There is a requirement to support 51.2MHz from GPLL6 for qup clocks, > thus update the frequency table and parent data/map to use the GPLL6 > source PLL. > > Signed-off-by: Taniya Das <tdas@...eaurora.org> > --- Any Fixes: tag for this? I guess the beginning of this driver being introduced? > drivers/clk/qcom/gcc-sc7180.c | 73 ++++++++++++++++++++++--------------------- > 1 file changed, 37 insertions(+), 36 deletions(-) > > diff --git a/drivers/clk/qcom/gcc-sc7180.c b/drivers/clk/qcom/gcc-sc7180.c > index 7f59fb8..ad75847 100644 > --- a/drivers/clk/qcom/gcc-sc7180.c > +++ b/drivers/clk/qcom/gcc-sc7180.c > @@ -405,8 +406,8 @@ static const struct freq_tbl ftbl_gcc_qupv3_wrap0_s0_clk_src[] = { > > static struct clk_init_data gcc_qupv3_wrap0_s0_clk_src_init = { > .name = "gcc_qupv3_wrap0_s0_clk_src", > - .parent_data = gcc_parent_data_0, > - .num_parents = 4, > + .parent_data = gcc_parent_data_1, This should have been done initially. We shouldn't need to describe "new" parents when they have always been there. Are there other clks in this driver that actually have more parents than we've currently described? If so, please fix them. > + .num_parents = 5, Can you use ARRAY_SIZE(gcc_parent_data_1) instead? That way this isn't a hard-coded value. > .ops = &clk_rcg2_ops, > }; >
Powered by blists - more mailing lists