linux-kernel - Re: [PATCH 1/2] thermal: qoriq: Use devm_add_action_or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a2b5e9e6-7564-f2c9-67ac-54e0d76f542e@linaro.org>
Date:   Tue, 17 Mar 2020 10:07:24 +0100
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Anson Huang <anson.huang@....com>,
        "rui.zhang@...el.com" <rui.zhang@...el.com>,
        "amit.kucheria@...durent.com" <amit.kucheria@...durent.com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:     dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH 1/2] thermal: qoriq: Use devm_add_action_or_reset() to
 handle all cleanups

On 17/03/2020 02:14, Anson Huang wrote:
> Hi, Daniel
> 
>> Subject: RE: [PATCH 1/2] thermal: qoriq: Use devm_add_action_or_reset() to
>> handle all cleanups
>>

[ ... ]

>>>>> Is this change compatible with the tristate?
>>>>
>>>> I think so, any concern need me to double confirm?
>>>
>>> TBH, I discovered the function with your patch. My concern is if the
>>> callback is called when unloading the module.
>>
>> I think so as per my memory, see similar patches as below:
>>
>>
>> commit 19ec11a2233d24a7811836fa735203aaccf95a23
>> Author: Bartosz Golaszewski <bgolaszewski@...libre.com>
>> Date:   Thu Jul 11 10:29:35 2019 +0200
>>
>>     gpio: em: remove the gpiochip before removing the irq domain
>>
>>     In commit 8764c4ca5049 ("gpio: em: use the managed version of
>>     gpiochip_add_data()") we implicitly altered the ordering of resource
>>     freeing: since gpiochip_remove() calls gpiochip_irqchip_remove()
>>     internally, we now can potentially use the irq_domain after it was
>>     destroyed in the remove() callback (as devm resources are freed after
>>     remove() has returned).
>>
>>     Use devm_add_action_or_reset() to keep the ordering right and entirely
>>     kill the remove() callback in the driver.
>>
>>
>> commit d9aa5ca429ad30dde96e5966173d18004f16f312
>> Author: Alexandre Belloni <alexandre.belloni@...tlin.com>
>> Date:   Fri Apr 19 10:25:01 2019 +0200
>>
>>     rtc: ds2404: simplify .probe and remove .remove
>>
>>     Use devm_add_action_or_reset to simplify .probe and remove .remove
>>
>>     Signed-off-by: Alexandre Belloni <alexandre.belloni@...tlin.com>
>>
>> drivers/rtc/rtc-ds2404.c
> 
> Any further concern?

No more concerns, I've applied the patches.

Thanks
  -- Daniel


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog