linux-kernel - Re: [PATCH v1 1/1] firmware: tee_bnxt: remove unused variable init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e94bbb2c-6f36-61bb-d26a-2ce3e1a139e0@cogentembedded.com>
Date:   Tue, 17 Mar 2020 12:09:32 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Rayagonda Kokatanur <rayagonda.kokatanur@...adcom.com>,
        Rafał Miłecki <zajec5@...il.com>,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        BCM Kernel Feedback <bcm-kernel-feedback-list@...adcom.com>
Subject: Re: [PATCH v1 1/1] firmware: tee_bnxt: remove unused variable init

Hello!

On 17.03.2020 7:07, Rayagonda Kokatanur wrote:

> Remove unused variable initialization.

    I think it's not an initialization, it's an assignment. :-)

> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@...adcom.com>
> ---
>   drivers/firmware/broadcom/tee_bnxt_fw.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
> index ed10da5313e8..6fd62657e35f 100644
> --- a/drivers/firmware/broadcom/tee_bnxt_fw.c
> +++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
> @@ -143,8 +143,6 @@ int tee_bnxt_copy_coredump(void *buf, u32 offset, u32 size)
>   	prepare_args(TA_CMD_BNXT_COPY_COREDUMP, &arg, param);
>   
>   	while (rbytes)  {
> -		nbytes = rbytes;
> -
>   		nbytes = min_t(u32, rbytes, param[0].u.memref.size);
>   
>   		/* Fill additional invoke cmd params */

MBR, Sergei