linux-kernel - Re: [PATCH v1 1/1] firmware: tee_bnxt: remove unused variable init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHO=5PEiPK=uF_rEJ+ujaP=oq2fPR1VHvczjZ1JQAqDdjTsMHQ@mail.gmail.com>
Date:   Tue, 17 Mar 2020 15:23:20 +0530
From:   Rayagonda Kokatanur <rayagonda.kokatanur@...adcom.com>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:     Rafał Miłecki <zajec5@...il.com>,
        linux-mips@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        BCM Kernel Feedback <bcm-kernel-feedback-list@...adcom.com>
Subject: Re: [PATCH v1 1/1] firmware: tee_bnxt: remove unused variable init

On Tue, Mar 17, 2020 at 2:39 PM Sergei Shtylyov
<sergei.shtylyov@...entembedded.com> wrote:
>
> Hello!
>
> On 17.03.2020 7:07, Rayagonda Kokatanur wrote:
>
> > Remove unused variable initialization.
>
>     I think it's not an initialization, it's an assignment. :-)
Thanks  will fix it and send v2.
>
> > Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@...adcom.com>
> > ---
> >   drivers/firmware/broadcom/tee_bnxt_fw.c | 2 --
> >   1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
> > index ed10da5313e8..6fd62657e35f 100644
> > --- a/drivers/firmware/broadcom/tee_bnxt_fw.c
> > +++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
> > @@ -143,8 +143,6 @@ int tee_bnxt_copy_coredump(void *buf, u32 offset, u32 size)
> >       prepare_args(TA_CMD_BNXT_COPY_COREDUMP, &arg, param);
> >
> >       while (rbytes)  {
> > -             nbytes = rbytes;
> > -
> >               nbytes = min_t(u32, rbytes, param[0].u.memref.size);
> >
> >               /* Fill additional invoke cmd params */
>
> MBR, Sergei