linux-kernel - Re: [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b049be1c-1f3f-54fc-3c47-0873d95cb769@roeck-us.net>
Date:   Mon, 16 Mar 2020 19:32:46 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Peng Fan <peng.fan@....com>, Anson Huang <anson.huang@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     Shawn Guo <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "dmitry.torokhov@...il.com" <dmitry.torokhov@...il.com>,
        "a.zummo@...ertech.it" <a.zummo@...ertech.it>,
        "rui.zhang@...el.com" <rui.zhang@...el.com>,
        "daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>,
        "amit.kucheria@...durent.com" <amit.kucheria@...durent.com>,
        "wim@...ux-watchdog.org" <wim@...ux-watchdog.org>,
        Daniel Baluta <daniel.baluta@....com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux@...pel-privat.de" <linux@...pel-privat.de>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "m.felsch@...gutronix.de" <m.felsch@...gutronix.de>,
        "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>,
        "arnd@...db.de" <arnd@...db.de>,
        "ronald@...ovation.ch" <ronald@...ovation.ch>,
        "krzk@...nel.org" <krzk@...nel.org>,
        "robh@...nel.org" <robh@...nel.org>,
        Leonard Crestez <leonard.crestez@....com>,
        Aisheng Dong <aisheng.dong@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU case

On 3/16/20 7:18 PM, Peng Fan wrote:
>> Subject: RE: [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU
>> case
>>
>> Hi, Alexandre
>>
>>> -----Original Message-----
>>> From: Alexandre Belloni <alexandre.belloni@...tlin.com>
>>> Sent: Monday, March 16, 2020 5:16 PM
>>> To: Anson Huang <anson.huang@....com>
>>> Cc: Shawn Guo <shawnguo@...nel.org>; Peng Fan <peng.fan@....com>;
>>> s.hauer@...gutronix.de; kernel@...gutronix.de; festevam@...il.com;
>>> dmitry.torokhov@...il.com; a.zummo@...ertech.it;
>> rui.zhang@...el.com;
>>> daniel.lezcano@...aro.org; amit.kucheria@...durent.com; wim@...ux-
>>> watchdog.org; linux@...ck-us.net; Daniel Baluta
>>> <daniel.baluta@....com>; gregkh@...uxfoundation.org;
>>> linux@...pel-privat.de; tglx@...utronix.de; m.felsch@...gutronix.de;
>>> andriy.shevchenko@...ux.intel.com;
>>> arnd@...db.de; ronald@...ovation.ch; krzk@...nel.org; robh@...nel.org;
>>> Leonard Crestez <leonard.crestez@....com>; Aisheng Dong
>>> <aisheng.dong@....com>; linux-arm-kernel@...ts.infradead.org; linux-
>>> kernel@...r.kernel.org; linux-input@...r.kernel.org; linux-
>>> rtc@...r.kernel.org; linux-pm@...r.kernel.org; linux-
>>> watchdog@...r.kernel.org; dl-linux-imx <linux-imx@....com>
>>> Subject: Re: [PATCH V3 1/7] firmware: imx: Add stubs for
>>> !CONFIG_IMX_SCU case
>>>
>>> On 16/03/2020 09:08:53+0000, Anson Huang wrote:
>>>>> Why do you absolutely need to compile them independently? From a
>>>>> code coverage point of view, having:
>>>>>
>>>>> COMPILE_TEST=y
>>>>> CONFIG_IMX_SCU=y
>>>>>
>>>>> is enough to select and compile the remaining drivers.
>>>>
>>>> What I meant is for below case, like using other arch config which
>>>> does NOT have CONFIG_IMX_SCU selected, ONLY with COMPILE_TEST
>>>> selected, adding stubs for IMX_SCU APIs can fix such scenario.
>>>>
>>>> COMPILE_TEST=y
>>>> CONFIG_IMX_SCU=n
>>>>
>>>
>>> Why is that an issue? If they don't have IMX_SCU selected, then the
>>> other SCU driver are not selected either, having stubs doesn't change
>>> that you will have to select at least one option. Please explain what
>>> is the issue that is not solved here.
>>
>> OK, what I thought is even without IMX_SCU selected, other SCU drivers still
>> can be selected for build test after adding "COMPILE_TEST" to the kconfig,
>> like below, if without IMX_SCU API stubs, the "COMPILE_TEST" can NOT be
>> added to SCU drivers to enable build test, so I think the IMX_SCU API stubs
>> should be added?
> 
> Forgot to mention, without stub api, for drivers with
> " #include <linux/firmware/imx/sci.h> " will met compile error without
> +#ifdef CONFIG_IMX_SCU
> +#endif
> 
> So we have to use ifdef CONFIG_IMX_SCU to guard the include.
> 
Add "depends on IMX_SCU" to the Kconfig entry for those drivers,
and/or drop "COMPILE_TEST" from their Kconfig entry.

Really, COMPILE_TEST is abused here. I start to understand those who
advocate that it should be removed. This is an excellent case in point.

Guenter