linux-kernel - Re: [PATCH] arm64: dts: qcom: sc7180: Changed polling-delay in Thermal-zones node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 18 Mar 2020 14:40:47 +0530
From:   Amit Kucheria <amit.kucheria@...durent.com>
To:     "Rajeshwari Ravindra Kamble (Temp)" <rkambl@...eaurora.org>
Cc:     Doug Anderson <dianders@...omium.org>,
        Andy Gross <agross@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
        sivaa@...eaurora.org, Sandeep Maheswaram <sanm@...eaurora.org>
Subject: Re: [PATCH] arm64: dts: qcom: sc7180: Changed polling-delay in
 Thermal-zones node

On Wed, Mar 18, 2020 at 11:49 AM Rajeshwari Ravindra Kamble (Temp)
<rkambl@...eaurora.org> wrote:
>
>
> On 3/17/2020 10:20 PM, Doug Anderson wrote:
>
> Hi,
>
> On Tue, Mar 17, 2020 at 12:42 AM Rajeshwari <rkambl@...eaurora.org> wrote:
>
> Changed polling-delay and polling-delay-passive to zero as per
> the requirement.
>
> Signed-off-by: Rajeshwari <rkambl@...eaurora.org>
> ---
>  arch/arm64/boot/dts/qcom/sc7180.dtsi | 100 +++++++++++++++++------------------
>  1 file changed, 50 insertions(+), 50 deletions(-)
>
> It probably wouldn't hurt to mention in the commit message that this
> is because the thermal sensor interrupts are all hooked up and thus
> the polling is not a useful thing to do.  ...but other than that:
>
> Reviewed-by: Douglas Anderson <dianders@...omium.org>
>
>
> Hi Douglas
>
> I didn't  get your comment.
>
> Thanks,
> Rajeshwari

I think he means that you haven't mentioned WHY this patch is needed
in the message. The reason you should mention is "to disable polling
mode of the framework since interrupts for tsens are already
configured."

Regards,
Amit