linux-kernel - Re: [PATCH] mmc: rtsx: Fixed TX/RX register and optimized TX parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200318104321.GA2303953@kroah.com>
Date:   Wed, 18 Mar 2020 11:43:21 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Ulf Hansson <ulf.hansson@...aro.org>
Cc:     吳昊澄 Ricky <ricky_wu@...ltek.com>,
        Arnd Bergmann <arnd@...db.de>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: rtsx: Fixed TX/RX register and optimized TX
 parameter

On Tue, Mar 17, 2020 at 12:58:35PM +0100, Ulf Hansson wrote:
> On Tue, 17 Mar 2020 at 03:45, 吳昊澄 Ricky <ricky_wu@...ltek.com> wrote:
> >
> >
> > > -----Original Message-----
> > > From: Ulf Hansson [mailto:ulf.hansson@...aro.org]
> > > Sent: Monday, March 16, 2020 10:17 PM
> > > To: 吳昊澄 Ricky
> > > Cc: linux-mmc@...r.kernel.org; Linux Kernel Mailing List; Arnd Bergmann; Greg
> > > Kroah-Hartman
> > > Subject: Re: [PATCH] mmc: rtsx: Fixed TX/RX register and optimized TX
> > > parameter
> > >
> > > On Mon, 16 Mar 2020 at 03:52, <ricky_wu@...ltek.com> wrote:
> > > >
> > > > From: Ricky Wu <ricky_wu@...ltek.com>
> > > >
> > > > Fixed sd_change_phase TX/RX register
> > > > Optimized rts522a rts524a rts525a rts5260 rts5261 TX initial parameter
> > >
> > > I don't understand what this actually fixes. Can you try to elaborate
> > > a bit on this, please?
> > >
> > > Do you think this is needed for stable, then why?
> >
> > Yes, I think it need patch to stable
> >
> > In function sd_change_phase() whether it is TX or RX always write the same register(TX), so patch this function make RX and TX can change well.
> > At mmc stack mechanism do not tuning TX phase, so need give a stable parameter for TX phase(sdr104 sdr50 ddr50) at initial.
> 
> Alright, I took the liberty to clarify the changelog a bit according
> to this. Please have a look at my fixes branch and tell me if I should
> do some additional changes of the changelog.
> 
> Applied for fixes and by adding a stable tag, thanks!
> 
> Arnd, Greg, so I am picking this via my mmc tree, please shout at me
> (or ack it) if you have any concerns with this. :-)

No concerns at all!

Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>