linux-kernel - Re: [PATCH] drivers/i2c/busses/i2c-imx.c:remove duplicate print after platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200318104405.rsqiw5og4xbuv6n5@katana>
Date:   Wed, 18 Mar 2020 11:44:05 +0100
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc:     Tang Bin <tangbin@...s.chinamobile.com>, linux@...pel-privat.de,
        s.hauer@...gutronix.de, shawnguo@...nel.org,
        linux-i2c@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/i2c/busses/i2c-imx.c:remove duplicate print
 after platform_get_irq()

Hi Uwe,

> Maybe add a comment for the next person who wonders about an error path
> without error message? Something like:
> 
> 	irq = platform_get_irq(pdev, 0);
> 	if (irq < 0)
> 		/*
> 		 * platform_get_irq() already issued an error message, so
> 		 * fail silently here.
> 		 */
> 		 return irq;

Hmm, too much boilerplate for my taste. I'd rather assume it will be
printed during the call.

> And to get some extra kudos mention the commit that modified
> platform_get_irq() to emit a message in the commit log.

Yes.

Kind regards,

   Wolfram


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)