linux-kernel - Re: [PATCH 11/14] efi/gop: Allow specifying mode number on command line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 20 Mar 2020 06:53:17 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Arvind Sankar <nivedita@...m.mit.edu>
Cc:     kbuild-all@...ts.01.org, Ard Biesheuvel <ardb@...nel.org>,
        linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/14] efi/gop: Allow specifying mode number on command
 line

Hi Arvind,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on efi/next]
[also build test WARNING on next-20200319]
[cannot apply to linux/master linus/master v5.6-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Arvind-Sankar/efi-gop-Refactoring-mode-setting-feature/20200320-044605
base:   https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git next
config: arm-multi_v7_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=9.2.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/firmware/efi/libstub/gop.c:25:1: warning: 'section' attribute does not apply to types [-Wattributes]
      25 | } __efistub_global cmdline = { .option = EFI_CMDLINE_NONE };
         | ^
   drivers/firmware/efi/libstub/gop.c: In function 'efi_setup_gop':
   drivers/firmware/efi/libstub/gop.c:116:21: warning: 'new_mode' may be used uninitialized in this function [-Wmaybe-uninitialized]
     116 |  if (efi_call_proto(gop, set_mode, new_mode) != EFI_SUCCESS)
         |                     ^~~
   drivers/firmware/efi/libstub/gop.c:100:16: note: 'new_mode' was declared here
     100 |  u32 cur_mode, new_mode;
         |                ^~~~~~~~

vim +/section +25 drivers/firmware/efi/libstub/gop.c

    21	
    22	static struct {
    23		enum efi_cmdline_option option;
    24		u32 mode;
  > 25	} __efistub_global cmdline = { .option = EFI_CMDLINE_NONE };
    26	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (49915 bytes)