linux-kernel - Re: [PATCH 11/14] efi/gop: Allow specifying mode number on command line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 20 Mar 2020 09:09:36 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Arvind Sankar <nivedita@...m.mit.edu>
Cc:     kbuild-all@...ts.01.org, Ard Biesheuvel <ardb@...nel.org>,
        linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/14] efi/gop: Allow specifying mode number on command
 line

Hi Arvind,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on efi/next]
[also build test WARNING on next-20200319]
[cannot apply to linux/master linus/master v5.6-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Arvind-Sankar/efi-gop-Refactoring-mode-setting-feature/20200320-044605
base:   https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git next
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=9.2.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   drivers/firmware/efi/libstub/gop.c: In function 'efi_setup_gop':
>> drivers/firmware/efi/libstub/gop.c:116:21: warning: 'new_mode' may be used uninitialized in this function [-Wmaybe-uninitialized]
     116 |  if (efi_call_proto(gop, set_mode, new_mode) != EFI_SUCCESS)
         |                     ^~~
   drivers/firmware/efi/libstub/gop.c:100:16: note: 'new_mode' was declared here
     100 |  u32 cur_mode, new_mode;
         |                ^~~~~~~~

vim +/new_mode +116 drivers/firmware/efi/libstub/gop.c

    96	
    97	static void set_mode(efi_graphics_output_protocol_t *gop)
    98	{
    99		efi_graphics_output_protocol_mode_t *mode;
   100		u32 cur_mode, new_mode;
   101	
   102		switch (cmdline.option) {
   103		case EFI_CMDLINE_NONE:
   104			return;
   105		case EFI_CMDLINE_MODE_NUM:
   106			new_mode = choose_mode_modenum(gop);
   107			break;
   108		}
   109	
   110		mode = efi_table_attr(gop, mode);
   111		cur_mode = efi_table_attr(mode, mode);
   112	
   113		if (new_mode == cur_mode)
   114			return;
   115	
 > 116		if (efi_call_proto(gop, set_mode, new_mode) != EFI_SUCCESS)
   117			efi_printk("Failed to set requested mode\n");
   118	}
   119	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (47131 bytes)