lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 20 Mar 2020 14:07:41 +0000 From: Qais Yousef <qais.yousef@....com> To: Catalin Marinas <catalin.marinas@....com> Cc: Thomas Gleixner <tglx@...utronix.de>, "Paul E . McKenney" <paulmck@...nel.org>, Will Deacon <will@...nel.org>, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v3 05/15] arm64: Don't use disable_nonboot_cpus() On 03/17/20 11:21, Catalin Marinas wrote: > On Sun, Feb 23, 2020 at 07:29:32PM +0000, Qais Yousef wrote: > > disable_nonboot_cpus() is not safe to use when doing machine_down(), > > because it relies on freeze_secondary_cpus() which in turn is > > a suspend/resume related freeze and could abort if the logic detects any > > pending activities that can prevent finishing the offlining process. > > > > Beside disable_nonboot_cpus() is dependent on CONFIG_PM_SLEEP_SMP which > > is an othogonal config to rely on to ensure this function works > > correctly. > > > > Use `reboot_cpu` variable instead of hardcoding 0 as the reboot cpu. > > > > Signed-off-by: Qais Yousef <qais.yousef@....com> > > CC: Catalin Marinas <catalin.marinas@....com> > > CC: Will Deacon <will@...nel.org> > > CC: linux-arm-kernel@...ts.infradead.org > > CC: linux-kernel@...r.kernel.org > > I'm not sure whether these patches have been queued already (still > unread in my inbox), so here it is: > > Acked-by: Catalin Marinas <catalin.marinas@....com> Thanks Catalin! Russel has requested to split the arm patch into 2 so that the change to use reboot_cpu is in a separate patch. I'll do the same for arm64 to stay consistent. I'll add your Acked-by to both patches if that's okay. Please shout if you have any objection. Thanks -- Qais Yousef
Powered by blists - more mailing lists