linux-kernel - Re: [PATCH] arch/um: falloc.h needs to be directly included for older libc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2295c218-74a6-d785-f4b1-2046ee91503a@cambridgegreys.com>
Date:   Fri, 20 Mar 2020 15:57:20 +0000
From:   Anton Ivanov <anton.ivanov@...bridgegreys.com>
To:     Alan Maguire <alan.maguire@...cle.com>, jdike@...toit.com,
        richard@....at, alex.dewar@....co.uk, erelx.geron@...el.com,
        johannes.berg@...el.com, arnd@...db.de,
        linux-um@...ts.infradead.org
Cc:     brendanhiggins@...gle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arch/um: falloc.h needs to be directly included for older
 libc



On 17/03/2020 17:35, Alan Maguire wrote:
> When building UML with glibc 2.17 installed, compilation
> of arch/um/os-Linux/file.c fails due to failure to find
> FALLOC_FL_PUNCH_HOLE and FALLOC_FL_KEEP_SIZE definitions.
> 
> It appears that /usr/include/bits/fcntl-linux.h (indirectly
> included by /usr/include/fcntl.h) does not include falloc.h
> with an older glibc, whereas a more up-to-date version
> does.
> 
> Adding the direct include to file.c resolves the issue
> and does not cause problems for more recent glibc.
> 
> Fixes: 50109b5a03b4 ("um: Add support for DISCARD in the UBD Driver")
> Cc: Brendan Higgins <brendanhiggins@...gle.com>
> Signed-off-by: Alan Maguire <alan.maguire@...cle.com>
> ---
>   arch/um/os-Linux/file.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/um/os-Linux/file.c b/arch/um/os-Linux/file.c
> index fbda105..5c819f8 100644
> --- a/arch/um/os-Linux/file.c
> +++ b/arch/um/os-Linux/file.c
> @@ -8,6 +8,7 @@
>   #include <errno.h>
>   #include <fcntl.h>
>   #include <signal.h>
> +#include <linux/falloc.h>
>   #include <sys/ioctl.h>
>   #include <sys/mount.h>
>   #include <sys/socket.h>
> 

Acked-By: Anton Ivanov <anton.ivanov@...bridgegreys.com>

-- 
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661
https://www.cambridgegreys.com/