linux-kernel - Re: [PATCH] arch/um: falloc.h needs to be directly included for older libc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFLxGvypQCHnnuRi8RC15wL3yJ7yBJiUQGMHG8MRoPeNA6pAPA@mail.gmail.com>
Date:   Sun, 29 Mar 2020 23:41:28 +0200
From:   Richard Weinberger <richard.weinberger@...il.com>
To:     Anton Ivanov <anton.ivanov@...bridgegreys.com>
Cc:     Alan Maguire <alan.maguire@...cle.com>,
        Jeff Dike <jdike@...toit.com>,
        Richard Weinberger <richard@....at>, alex.dewar@....co.uk,
        erelx.geron@...el.com, "Berg, Johannes" <johannes.berg@...el.com>,
        Arnd Bergmann <arnd@...db.de>,
        linux-um <linux-um@...ts.infradead.org>,
        Brendan Higgins <brendanhiggins@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arch/um: falloc.h needs to be directly included for older libc

On Fri, Mar 20, 2020 at 4:58 PM Anton Ivanov
<anton.ivanov@...bridgegreys.com> wrote:
>
>
>
> On 17/03/2020 17:35, Alan Maguire wrote:
> > When building UML with glibc 2.17 installed, compilation
> > of arch/um/os-Linux/file.c fails due to failure to find
> > FALLOC_FL_PUNCH_HOLE and FALLOC_FL_KEEP_SIZE definitions.
> >
> > It appears that /usr/include/bits/fcntl-linux.h (indirectly
> > included by /usr/include/fcntl.h) does not include falloc.h
> > with an older glibc, whereas a more up-to-date version
> > does.
> >
> > Adding the direct include to file.c resolves the issue
> > and does not cause problems for more recent glibc.
> >
> > Fixes: 50109b5a03b4 ("um: Add support for DISCARD in the UBD Driver")
> > Cc: Brendan Higgins <brendanhiggins@...gle.com>
> > Signed-off-by: Alan Maguire <alan.maguire@...cle.com>
> > ---
> >   arch/um/os-Linux/file.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/um/os-Linux/file.c b/arch/um/os-Linux/file.c
> > index fbda105..5c819f8 100644
> > --- a/arch/um/os-Linux/file.c
> > +++ b/arch/um/os-Linux/file.c
> > @@ -8,6 +8,7 @@
> >   #include <errno.h>
> >   #include <fcntl.h>
> >   #include <signal.h>
> > +#include <linux/falloc.h>
> >   #include <sys/ioctl.h>
> >   #include <sys/mount.h>
> >   #include <sys/socket.h>
> >
>
> Acked-By: Anton Ivanov <anton.ivanov@...bridgegreys.com>

Applied, thanks!

BTW: Anton & Brendan, thanks a lot for reviewing all these patches!

-- 
Thanks,
//richard