linux-kernel - Re: [PATCH v10 01/11] vfio: VFIO_IOMMU_SET_PASID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202003211339.suukYvtv%lkp@intel.com>
Date:   Sat, 21 Mar 2020 13:18:56 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Eric Auger <eric.auger@...hat.com>
Cc:     kbuild-all@...ts.01.org, eric.auger.pro@...il.com,
        eric.auger@...hat.com, iommu@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        kvmarm@...ts.cs.columbia.edu, joro@...tes.org,
        alex.williamson@...hat.com, jacob.jun.pan@...ux.intel.com,
        yi.l.liu@...el.com, jean-philippe.brucker@....com,
        will.deacon@....com, robin.murphy@....com, marc.zyngier@....com,
        peter.maydell@...aro.org, zhangfei.gao@...il.com
Subject: Re: [PATCH v10 01/11] vfio: VFIO_IOMMU_SET_PASID_TABLE

Hi Eric,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on vfio/next]
[also build test ERROR on v5.6-rc6 next-20200320]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Eric-Auger/SMMUv3-Nested-Stage-Setup-VFIO-part/20200321-040935
base:   https://github.com/awilliam/linux-vfio.git next
config: arm64-randconfig-a001-20200321 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=9.2.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/vfio.h:16,
                    from drivers/vfio/vfio.c:32:
>> include/uapi/linux/vfio.h:811:34: error: field 'config' has incomplete type
     811 |  struct iommu_pasid_table_config config; /* used on SET */
         |                                  ^~~~~~
--
   In file included from include/linux/vfio.h:16,
                    from drivers/vfio/vfio_iommu_type1.c:35:
>> include/uapi/linux/vfio.h:811:34: error: field 'config' has incomplete type
     811 |  struct iommu_pasid_table_config config; /* used on SET */
         |                                  ^~~~~~
   drivers/vfio/vfio_iommu_type1.c: In function 'vfio_detach_pasid_table':
>> drivers/vfio/vfio_iommu_type1.c:2204:3: error: implicit declaration of function 'iommu_detach_pasid_table'; did you mean 'vfio_detach_pasid_table'? [-Werror=implicit-function-declaration]
    2204 |   iommu_detach_pasid_table(d->domain);
         |   ^~~~~~~~~~~~~~~~~~~~~~~~
         |   vfio_detach_pasid_table
   drivers/vfio/vfio_iommu_type1.c: In function 'vfio_attach_pasid_table':
>> drivers/vfio/vfio_iommu_type1.c:2219:9: error: implicit declaration of function 'iommu_attach_pasid_table'; did you mean 'vfio_attach_pasid_table'? [-Werror=implicit-function-declaration]
    2219 |   ret = iommu_attach_pasid_table(d->domain, &ustruct->config);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~
         |         vfio_attach_pasid_table
   cc1: some warnings being treated as errors

vim +/config +811 include/uapi/linux/vfio.h

   797	
   798	/**
   799	 * VFIO_IOMMU_SET_PASID_TABLE - _IOWR(VFIO_TYPE, VFIO_BASE + 22,
   800	 *			struct vfio_iommu_type1_set_pasid_table)
   801	 *
   802	 * The SET operation passes a PASID table to the host while the
   803	 * UNSET operation detaches the one currently programmed. Setting
   804	 * a table while another is already programmed replaces the old table.
   805	 */
   806	struct vfio_iommu_type1_set_pasid_table {
   807		__u32	argsz;
   808		__u32	flags;
   809	#define VFIO_PASID_TABLE_FLAG_SET	(1 << 0)
   810	#define VFIO_PASID_TABLE_FLAG_UNSET	(1 << 1)
 > 811		struct iommu_pasid_table_config config; /* used on SET */
   812	};
   813	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (38936 bytes)