linux-kernel - Re: [PATCH] arm64: dts: rockchip: fix defines in pd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48029127.kezn7BFppT@diego>
Date:   Sun, 22 Mar 2020 19:03:35 +0100
From:   Heiko Stübner <heiko@...ech.de>
To:     Johan Jonker <jbx6244@...il.com>, Caesar Wang <wxt@...k-chips.com>,
        kever.yang@...k-chips.com
Cc:     devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org,
        robh+dt@...nel.org
Subject: Re: [PATCH] arm64: dts: rockchip: fix defines in pd_vio node for rk3399

Am Sonntag, 22. März 2020, 17:14:54 CET schrieb Johan Jonker:
> Hi,
> 
> Why is 'pd_tcpc0, pd_tcpc1' grouped under 'pd_vio' instead of VD_LOGIC?

^^
You'll need to add Rockchip-people for that - I've done that now ;-)



> On 3/22/20 4:45 PM, Johan Jonker wrote:
> > Hi,
> > 
> > The RK3399 TRM uses both
> > 
> > 'pd_tcpc0, pd_tcpc1'
> > 
> > as
> > 
> > 'pd_tcpd0, pd_tcpd1'.
> > 
> > What should we use here?

We should probably just fix the nodename as you did.
- For one tcpD seems to be appearing way more often than tcpC
- and of course the header is part of the binding itself, so that shouldn't
  change without a really good reason


Heiko

> > 
> > Thanks.
> > 
> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> >> index 8aac201f0..3dc8fe620 100644
> >> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> >> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> >> @@ -1087,12 +1087,12 @@
> >>  					pm_qos = <&qos_isp1_m0>,
> >>  						 <&qos_isp1_m1>;
> >>  				};
> >> -				pd_tcpc0@...399_PD_TCPC0 {
> >> +				pd_tcpc0@...399_PD_TCPD0 {
> >>  					reg = <RK3399_PD_TCPD0>;
> >>  					clocks = <&cru SCLK_UPHY0_TCPDCORE>,
> >>  						 <&cru SCLK_UPHY0_TCPDPHY_REF>;
> >>  				};
> >> -				pd_tcpc1@...399_PD_TCPC1 {
> >> +				pd_tcpc1@...399_PD_TCPD1 {
> >>  					reg = <RK3399_PD_TCPD1>;
> >>  					clocks = <&cru SCLK_UPHY1_TCPDCORE>,
> >>  						 <&cru SCLK_UPHY1_TCPDPHY_REF>;
> > 
> 
>